feat(3000): Add sites sidebar for Toolbar launching #16389
Conversation
📸 UI snapshots have been updated2 snapshot changes in total. 0 added, 2 modified, 0 deleted:
Triggered by this commit. |
There was a problem hiding this comment.
I really like the site concept! Code looks solid, one suggestion to add an enum.
Functionality wise I'm still missing being able to add other URLs besides the suggested ones and to edit the existing ones. Most importantly I can't launch the toolbar for local development e.g. to disable posthog-3000.
frontend/src/scenes/scenes.ts
Outdated
| @@ -210,12 +210,17 @@ export const sceneConfigurations: Partial<Record<Scene, SceneConfig>> = { | |||
| }, | |||
| [Scene.Ingestion]: { | |||
| projectBased: true, | |||
| plain: true, | |||
| plain: 2, | |||
There was a problem hiding this comment.
Can we add an enum for the different states?
There was a problem hiding this comment.
Hmm, enum might be overkill, but made this into variants. Take a look now
|
Good feedback about the lack of "New site" button being annoying, I have a branch in progress that adds that. Assuming that PR is the follow up to this one, do you think this is going to be good enough for now? |
|
BTW it is still possible to launch the site with toolbar in a new tab like in the classic navigation, it's in item menu. Maybe it was not clear that that includes the Toolbar, so renamed from "Open in new tab" to "Open with Toolbar in new tab". Alternatively maybe for important actions like that there could be an action button on items, which in this case would make "Open with Toolbar in new tab" prominent. (@corywatilo) |
Changes
It wasn't possible to launch the Toolbar in PostHog 3000. With the new "Sites" feature, it is. You can still open your sites in a new tab, but also view them inside PostHog, with the toolbar on.
Of course with iframes there are significant security considerations, and most importantly most web apps don't allow iframing by default. There's currently no education on resolving this in the app, but we can add it later on.