Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(decide): Add proper analytics for decide requests #15837

Merged
merged 19 commits into from
Jun 6, 2023

Conversation

neilkakkar
Copy link
Contributor

@neilkakkar neilkakkar commented Jun 1, 2023

Problem

We want to capture analytics for decide requests so we can charge for these.

We can't individually capture every request, because not only will that be very expensive, but also slow & almost unfeasible given the query volume. So, we aggregate per team:

  1. Redis has a dict for every team, a bucket that increments counters for number of requests coming in. Every 2 minutes, we create a new bucket.
  2. A background celery task reads from these buckets, and sums up count of all events in all buckets, upto the last bucket; and sends this as an event to posthog.

We do things like this so everything works in a distributed setting: There's a lock on the background celery task, so events aren't double counted (tests show this). While at the same time, this lock does not prevent request counts incrementing in the newest bucket.

We skip the newest bucket for the background task because the numbers in here are still increasing, and it wouldn't make sense to delete this bucket while there are still requests coming in for this bucket.


Now, once I know this works okay, I can add to the organisation usage report a query that sums all these counts per team.

One gotcha here is that since we're gathering data from both US and EU, we can't rely on the team_id, as it will duplicate between EU & US. Thus, we are using the team uuid.


I've also added an env var for now, so we can de-risk this going to prod. I'll switch it on only in dev first, see everything works fine, then go to prod.

Changes

👉 Stay up-to-date with PostHog coding conventions for a smoother review.

How did you test this code?

@posthog-bot
Copy link
Contributor

Hey @neilkakkar! 👋
This pull request seems to contain no description. Please add useful context, rationale, and/or any other information that will help make sense of this change now and in the distant Mars-based future.

@neilkakkar neilkakkar marked this pull request as ready for review June 1, 2023 14:40
@Twixes Twixes force-pushed the decide-analytics4 branch from 849f2c6 to a6cfcab Compare June 5, 2023 15:02
@neilkakkar neilkakkar force-pushed the decide-analytics4 branch from 97e8fee to a284675 Compare June 5, 2023 17:20
@neilkakkar neilkakkar merged commit db4d0a2 into master Jun 6, 2023
@neilkakkar neilkakkar deleted the decide-analytics4 branch June 6, 2023 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants