-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(decide): Add proper analytics for decide requests #15837
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hey @neilkakkar! 👋 |
neilkakkar
commented
Jun 1, 2023
EDsCODE
approved these changes
Jun 2, 2023
neilkakkar
force-pushed
the
decide-analytics4
branch
from
June 5, 2023 17:20
97e8fee
to
a284675
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We want to capture analytics for decide requests so we can charge for these.
We can't individually capture every request, because not only will that be very expensive, but also slow & almost unfeasible given the query volume. So, we aggregate per team:
We do things like this so everything works in a distributed setting: There's a lock on the background celery task, so events aren't double counted (tests show this). While at the same time, this lock does not prevent request counts incrementing in the newest bucket.
We skip the newest bucket for the background task because the numbers in here are still increasing, and it wouldn't make sense to delete this bucket while there are still requests coming in for this bucket.
Now, once I know this works okay, I can add to the organisation usage report a query that sums all these counts per team.
One gotcha here is that since we're gathering data from both US and EU, we can't rely on the team_id, as it will duplicate between EU & US. Thus, we are using the team uuid.
I've also added an env var for now, so we can de-risk this going to prod. I'll switch it on only in dev first, see everything works fine, then go to prod.
Changes
👉 Stay up-to-date with PostHog coding conventions for a smoother review.
How did you test this code?