Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(3000): Rename items directly in sidebar #15780

Merged
merged 4 commits into from
May 30, 2023
Merged

Conversation

Twixes
Copy link
Member

@Twixes Twixes commented May 30, 2023

Changes

We're building an app, not a website. So let's allow renaming things intuitively in the sidebar:
menu

In action:
action

@Twixes Twixes requested a review from thmsobrmlr May 30, 2023 10:08
@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

3 snapshot changes in total. 0 added, 3 modified, 0 deleted:

  • chromium: 0 added, 3 modified, 0 deleted (diff for shard 1)
  • webkit: 0 added, 0 modified, 0 deleted
  • firefox: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

Copy link
Contributor

@thmsobrmlr thmsobrmlr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Couldn't figure out why, but keyboard shortcuts don't work after I rename an item until I select a menu item again (probably loosing focus).

@Twixes
Copy link
Member Author

Twixes commented May 30, 2023

Yep, it was about losing focus. Found a simple solution, so fixed! Great catch.

@Twixes Twixes merged commit d713ab2 into master May 30, 2023
@Twixes Twixes deleted the posthog-3000-rename branch May 30, 2023 14:39
@Twixes Twixes mentioned this pull request Oct 19, 2023
41 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants