Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: shared dashboards with text cards #12741

Merged
merged 1 commit into from
Nov 10, 2022
Merged

fix: shared dashboards with text cards #12741

merged 1 commit into from
Nov 10, 2022

Conversation

pauldambra
Copy link
Member

@pauldambra pauldambra commented Nov 10, 2022 •
edited
Loading

Problem

Discovered that you couldn't load shared dashboards if they have text cards.

see remarkjs/react-markdown#339

Changes

we don't actually need process to do anything... so make it present and useless

without fix

Screenshot 2022-11-10 at 21 12 21

with fix

Screenshot 2022-11-10 at 21 12 30

How did you test this code?

  • sharing a dashboard with a text card on and seeing that this change made it possible to visit it
  • visiting the unshared dashboard
  • exporting the dashboard to PNG

@mariusandra mariusandra merged commit 7c991d9 into master Nov 10, 2022
@mariusandra mariusandra deleted the fix/shared-dashboard-with-text-cards branch November 10, 2022 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pauldambra @mariusandra