fix: change timestamps to be timezone aware upon parsing #11935
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…og/posthog into refactor-timestamp-handling-scheme
…og/posthog into refactor-timestamp-handling-scheme
…og/posthog into refactor-timestamp-handling-scheme
…og/posthog into refactor-timestamp-handling-scheme
…og/posthog into refactor-timestamp-handling-scheme
…og/posthog into refactor-timestamp-handling-scheme
…og/posthog into refactor-timestamp-handling-scheme
neilkakkar
reviewed
Oct 12, 2022
posthog/queries/query_date_range.py
Outdated
| @@ -176,9 +173,11 @@ def _get_timezone_aware_date_condition(self, operator: str, date_clause: str) -> | |||
| # Convert target to UTC so that stored timestamps can be compared accordingly | |||
There was a problem hiding this comment.
Out of date? Now we're treating target as team timezone
neilkakkar
approved these changes
Oct 12, 2022
neilkakkar
reviewed
Oct 12, 2022
| @@ -211,8 +211,8 @@ def get_event_query(self) -> Tuple[str, Dict[str, Any]]: | |||
| query = f""" | |||
| WITH | |||
| funnel_actors as ({funnel_persons_query}), | |||
| toDateTime(%(date_to)s) AS date_to, | |||
| toDateTime(%(date_from)s) AS date_from, | |||
| toDateTime(%(date_to)s, %(timezone)s) AS date_to, | |||
There was a problem hiding this comment.
funnel correlations should have toTimeZone here as well?
…og/posthog into refactor-timestamp-handling-scheme
…og/posthog into refactor-timestamp-handling-scheme
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
key changes:
Changes
👉 Stay up-to-date with PostHog coding conventions for a smoother review.
How did you test this code?