Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement new PersonModal for funnels #4819

Closed
paolodamico opened this issue Jun 21, 2021 · 6 comments
Closed

Implement new PersonModal for funnels #4819

paolodamico opened this issue Jun 21, 2021 · 6 comments
Assignees
@liyiy
Labels
enhancement New feature or request feature/funnels Feature Tag: Funnels

Comments

@paolodamico
Copy link
Contributor

Part of #4785. Implement the new PersonModal as detailed in the product specs. Mockups can be found on Figma.
@paolodamico paolodamico added enhancement New feature or request feature/funnels Feature Tag: Funnels core-experience labels Jun 21, 2021
@paolodamico
Copy link
Contributor Author

@mariusandra this is now fully unblocked and ready to be assigned

@paolodamico paolodamico mentioned this issue Jun 21, 2021
Closed
@liyiy liyiy self-assigned this Jun 21, 2021
@liyiy
Copy link
Contributor

liyiy commented Jun 21, 2021

Updates to the modal like filtering, sessions recording, etc can be worked on but implementing the persons modal for funnels might be blocked until querying can tackle on the backend for it

@EDsCODE

@liyiy liyiy mentioned this issue Jun 21, 2021
Closed
@paolodamico
Copy link
Contributor Author

Makes total sense. We're tracking the necessary API work in #4818

@mariusandra mariusandra mentioned this issue Jul 1, 2021
Closed
@liyiy liyiy mentioned this issue Jul 7, 2021
Closed
@mariusandra
Copy link
Collaborator

For lack of a better place to post this, I seem to be experiencing a bug where I can't save a dropoff as a cohort:

2021-07-14 16 02 22

The completed people save fine.

@mariusandra
Copy link
Collaborator

Also this: #5092 (comment)

@paolodamico
Copy link
Contributor Author

I think this can be closed now @liyiy ?

@liyiy liyiy closed this as completed Jul 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@liyiy liyiy

Labels
enhancement New feature or request feature/funnels Feature Tag: Funnels
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mariusandra @paolodamico @liyiy