Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Only match if URL contains" does not work as expected when creating an Action #236

Closed
mrsweaters opened this issue Feb 28, 2020 · 4 comments
Closed

"Only match if URL contains" does not work as expected when creating an Action #236

mrsweaters opened this issue Feb 28, 2020 · 4 comments
Assignees
@timgl
Labels
bug Something isn't working right

Comments

@mrsweaters
Copy link

If I enter example.com/register in the "URL contains" input i would expect the results to include those with that url. If I uncheck the filter and save, then I get event matches that contain example.com/register. Event if I try register nothing gets matched.
@mrsweaters mrsweaters changed the title Only match if URL contains does not work as expected when creating an Action "Only match if URL contains" does not work as expected when creating an Action Feb 28, 2020
@wundo
Copy link

wundo commented Mar 2, 2020

I'm experiencing the same behaviour

@jamesefhawkins jamesefhawkins added the bug Something isn't working right label Mar 2, 2020
@jamesefhawkins jamesefhawkins mentioned this issue Mar 2, 2020
Closed
@jamesefhawkins
Copy link
Collaborator

Thank you for reporting this issue.

"only match if URL contains" is currently an exact match type, rather than a "phrase" match. This contradicts the wording and isn't the intended behavior.

@mrsweaters
Copy link
Author

mrsweaters commented Mar 2, 2020 •
edited
Loading

The interesting thing is that I wasn't even able to get exact match to work correctly. I would copy the url from the event and paste it into the URL match input and it would disappear. I'm not sure how to get anything to match.

@jamesefhawkins jamesefhawkins added this to the Get the basic functionality completed milestone Mar 3, 2020
@jamesefhawkins jamesefhawkins assigned timgl and unassigned timgl and jamesefhawkins Mar 3, 2020
@timgl timgl closed this as completed in aed16fc Mar 4, 2020
timgl added a commit that referenced this issue Mar 4, 2020
@timgl
Merge pull request #267 from PostHog/236-url-exact-or-contains-matching
d2df094 
Closes #236 add url matching exact or contains
@timgl
Copy link
Collaborator

timgl commented Mar 4, 2020

Fixed! You can now select whether you want the url to contain your input, or exactly match.
image

yakkomajuri pushed a commit that referenced this issue Oct 1, 2021
@macobo
Always set created_at/updated_at in tests (#236)
b986b4e 
* Always set created_at/updated_at in tests

After #3607 this is mandatory

* Cleanup after schedule tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@timgl timgl

Labels
bug Something isn't working right
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@wundo @mrsweaters @timgl @jamesefhawkins