Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Survey responses count is inefficient #21775

Closed
neilkakkar opened this issue Apr 23, 2024 · 1 comment · Fixed by #22011
Closed

Survey responses count is inefficient #21775

neilkakkar opened this issue Apr 23, 2024 · 1 comment · Fixed by #22011
Assignees
@Phanatic
Labels
bug Something isn't working right feature/surveys good first issue Good for newcomers

Comments

@neilkakkar
Copy link
Contributor

Bug Description

Bug description

Realised thanks to #21528 - that our responses count endpoint for surveys list queries data from all time which can be pretty slow on big teams. This should instead use the earliest created date, like in the PR above to query responses count.

Please describe.
If this affects the front-end, screenshots would be of great help.

If you are on PostHog Cloud it would be really valuable if you can share any links where the problem occurs. This speeds up our ability to troubleshoot tremendously.

How to reproduce

Additional context

Debug info

- [ ] PostHog Cloud, Debug information: [please copy/paste from https://us.posthog.com/settings/project-details#variables]
- [ ] PostHog Hobby self-hosted with `docker compose`, version/commit: [please provide]
- [ ] PostHog self-hosted with Kubernetes (deprecated, see [`Sunsetting Kubernetes support`](https://posthog.com/blog/sunsetting-helm-support-posthog)), version/commit: [please provide]
@neilkakkar neilkakkar added bug Something isn't working right feature/surveys good first issue Good for newcomers labels Apr 23, 2024
@abdulhakkeempa
Copy link

@neilkakkar could you please describe more about this issue?

@Phanatic Phanatic self-assigned this May 1, 2024
@Phanatic Phanatic mentioned this issue May 1, 2024
Merged
Phanatic added a commit that referenced this issue May 2, 2024
@Phanatic
fix(survey): filter survey responses count by earliest survey created…
ab33abb 
… in a team (#22011)

Resolves #21775

This PR addresses an issue with how we calculate response counts for a given survey in the surveys UI.
Instead of filtering out all events for a team by the event name of survey sent, we will look at only those events that are created after the team created their first survey. This should be a good indicator for when we should start to see survey responses for a given team.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Phanatic Phanatic

Labels
bug Something isn't working right feature/surveys good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(survey): filter survey responses count by earliest survey created in a team PostHog/posthog
3 participants
@Phanatic @neilkakkar @abdulhakkeempa