Fix dashboard colors with non-white backgrounds (#2911)

* fix local variable bug * add "no-shadow" rule as a warning * fix two blue lines on line graphs
PostHog · Jan 12, 2021 · 1031329 · 1031329
1 parent b70f5b5
commit 1031329
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 3 deletions.
diff --git a/.eslintrc.js b/.eslintrc.js
@@ -42,6 +42,7 @@ module.exports = {
         '@typescript-eslint/explicit-module-boundary-types': 'off',
         '@typescript-eslint/no-empty-function': 'off',
         '@typescript-eslint/no-inferrable-types': 'off',
+        'no-shadow': 'warn',
         curly: 'error',
     },
     overrides: [

diff --git a/frontend/src/global.scss b/frontend/src/global.scss
@@ -17,7 +17,7 @@ style files without adding already imported styles. */
     --muted: #{$text_muted};
     // Used for graph series
     --blue: #{$blue_500};
-    --purple: #{purple_500};
+    --purple: #{$purple_500};
     --salmon: #ff906e;
     --yellow: #ffc035;
     --green: #{$success};

diff --git a/frontend/src/scenes/insights/LineGraph.js b/frontend/src/scenes/insights/LineGraph.js
@@ -113,10 +113,10 @@ export function LineGraph({
 
     function processDataset(dataset, index) {
         const colorList = getChartColors(color || 'white')
-        const color = dataset?.status ? getBarColorFromStatus(dataset.status) : colorList[index]
+        const borderColor = dataset?.status ? getBarColorFromStatus(dataset.status) : colorList[index]
 
         return {
-            borderColor: color,
+            borderColor,
             backgroundColor: (type === 'bar' || type === 'doughnut') && color,
             fill: false,
             borderWidth: 1,