-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Feature Flags support #29
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please please never mix code formatting changes with behavior changes. I made #30 to make this reviewable. Now this PR only includes material updates to the code.
A couple of comments besides that but overall this looks reasonable.
@Twixes yeah I do apologize for the |
Ready to go |
Also writing docs now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Letsgooo
Awesome 🥇 |
Dear Reviewer
Given
prettier
was run here, feature-flags.js and test.js are the places to focus most of the energy on.What this does
prettier
What this does not do
How the feature flags work
This follows the
posthog-python
implementation almost exactly.Follow-up work
posthog-python
code somewhat serves as this, but we need a place that at least tells us how to correctly calculate simple flags so we don't end up with diverging implementations. I spent some time playing around withcrypto
to get this right.