feat(web-analytics): Send timezone to flags v2 #1849
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's needed to figure out the user's calendar date, for the cookieless hash
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
robbie-c
commented
Mar 26, 2025
| @@ -71,6 +71,14 @@ export default function Home() { | |||
|
|
|||
| <button className="ph-no-capture">Ignore certain elements</button> | |||
|
|
|||
| <button | |||
| onClick={() => { | |||
| posthog?.reloadFeatureFlags() | |||
There was a problem hiding this comment.
I just included this button here as it's a reliable way to trigger a call to the flags endpoint
There was a problem hiding this comment.
PR Summary
Adds timezone information to feature flag requests when using flags v2 API, enabling proper calendar date determination for cookieless hash functionality.
- Added timezone parameter in
src/posthog-featureflags.tswhen both__preview_flags_v2and__preview_remote_configconfigs are enabled - Added
reloadFeatureFlagsbutton in playground app for testing flag reloading functionality - Implementation maintains backward compatibility by only adding timezone for v2 API requests
- Uses existing
Info.timezone()utility to retrieve timezone data
2 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
|
Size Change: +300 B (+0.01%) Total Size: 3.64 MB
ℹ️ View Unchanged
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Send timezone to flags v2. It's needed to figure out the user's calendar date, for the cookieless hash. We should merge PostHog/posthog#30304 first
Checklist