Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: initializing surveys twice and calling survey shown/dismissed more than once per survey #1747

Merged
merged 16 commits into from
Feb 22, 2025
Merged

fix: initializing surveys twice and calling survey shown/dismissed more than once per survey #1747

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
122423e
fix: initializing surveys twice and calling survey shown/dismissed mo…
lucasheriques Feb 18, 2025
aab0e42
review changes
lucasheriques Feb 19, 2025
b50c172
more review changes, and tests
lucasheriques Feb 19, 2025
af8246d
fix survey tests
lucasheriques Feb 19, 2025
572b7da
instantiate SurveyEventReceiver only once
lucasheriques Feb 19, 2025
1a5ce0b
readd event survey on getSurveys method
lucasheriques Feb 19, 2025
801ec47
merge master
lucasheriques Feb 20, 2025
c2549f5
add surveys_request_timeout_ms config
lucasheriques Feb 20, 2025
5a560cf
update config snapshot
lucasheriques Feb 20, 2025
56e2c7a
remove double check - not needed
lucasheriques Feb 20, 2025
92d7ee4
move _isInitializingSurveys to inside the callback
lucasheriques Feb 20, 2025
1021524
add default value for survey timeout
lucasheriques Feb 20, 2025
cbe769e
change test to call loadIfEnabled before
lucasheriques Feb 20, 2025
e041057
add log for survey loaded successfully
lucasheriques Feb 20, 2025
568e4e5
missed one test
lucasheriques Feb 20, 2025
899bff9
review changes
lucasheriques Feb 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/__tests__/__snapshots__/config-snapshot.test.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -344,6 +344,7 @@ exports[`config snapshot for PostHogConfig 1`] = `
\\"true\\"
],
\\"feature_flag_request_timeout_ms\\": \\"number\\",
\\"surveys_request_timeout_ms\\": \\"number\\",
\\"get_device_id\\": \\"(uuid: string) => string\\",
\\"before_send\\": [
\\"undefined\\",
Expand Down
Loading
Loading