chore: Drop CI support for Node 16 (EOL), use pnpm 9 internally #1723
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
PR Summary
This PR standardizes the pnpm package manager version to 9.x.x across the posthog-js repository to match the main PostHog repository's configuration.
- Added
packageManagerfield in package.json files to enforce pnpm@9.15.4 - Updated pnpm version from 8.x.x to 9.x.x across all GitHub workflow files
- Upgraded posthog-js dependency in playground/nextjs from 1.200.1 to 1.208.1
- Inconsistent usage of actions/checkout versions (v2 vs v4) in CD workflow needs standardization
- Mixed usage of npm/pnpm commands in react/package.json scripts should be unified
12 file(s) reviewed, 4 comment(s)
Edit PR Review Bot Settings | Greptile
| @@ -30,7 +30,7 @@ jobs: | |||
| - uses: actions/checkout@v4 | |||
| - uses: pnpm/action-setup@v4 | |||
| with: | |||
| version: 8.x.x | |||
| version: 9.x.x | |||
| - uses: actions/setup-node@v4 | |||
| with: | |||
| node-version: '18' | |||
There was a problem hiding this comment.
style: Missing cache: 'pnpm' configuration for Node setup in integration job, while it's present in other jobs
| node-version: '18' | |
| node-version: '18' | |
| cache: 'pnpm' |
.github/workflows/testcafe.yml
Outdated
| @@ -38,7 +38,7 @@ jobs: | |||
| - uses: actions/checkout@v4 | |||
| - uses: pnpm/action-setup@v4 | |||
| with: | |||
| version: 8.x.x | |||
| version: 9.x.x | |||
There was a problem hiding this comment.
style: Consider pinning to a specific 9.x version rather than using 9.x.x to ensure consistent builds
| @@ -21,7 +22,7 @@ | |||
| "eslint": "^8.57.1", | |||
There was a problem hiding this comment.
style: eslint should typically be in devDependencies since it's a development tool, not a runtime dependency
| "eslint": "^8.57.1", | |
| "eslint": "^8.57.1" |
| @@ -10,6 +10,7 @@ | |||
| }, | |||
| "author": "hey@posthog.com", | |||
| "license": "MIT", | |||
| "packageManager": "pnpm@9.15.4", | |||
| "scripts": { | |||
| "prebuild": "npm run clean", | |||
There was a problem hiding this comment.
style: Should use pnpm clean instead of npm run clean for consistency with other scripts
| "prebuild": "npm run clean", | |
| "prebuild": "pnpm clean", |
|
Size Change: 0 B Total Size: 3.3 MB ℹ️ View Unchanged
|
Changes
We use pnpm 9 in posthog/posthog, so use it here for consistency.
This requires dropping CI support for Node 16, but this is EOL, and shouldn't be used regardless.
See:
Checklist