Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(surveys): add Vite devserver #1164

Merged
merged 8 commits into from
May 7, 2024
Merged

Conversation

jurajmajerik
Copy link
Contributor

@jurajmajerik jurajmajerik commented May 6, 2024

Changes

Adds a Vite dev environment for a quicker development of the survey popup.

image

Running Instructions

cd playground/vite-surveys

pnpm install

pnpm run dev

Known issues

  • Multiple choice surveys conflict with each other - when a choice in the second survey one is selected, the first survey's choice gets highlighted. This is due to conflicting question input ID (all questions have index 0).
  • Only single questions can be previewed as yet - it would be nice to be able to set up and test the entire flow for a single survey.

Copy link

vercel bot commented May 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
posthog-js ✅ Ready (Inspect) Visit Preview May 7, 2024 1:13pm

Copy link

github-actions bot commented May 6, 2024

Size Change: +548 B (0%)

Total Size: 973 kB

Filename Size Change
dist/array.full.js 234 kB +137 B (0%)
dist/array.js 131 kB +137 B (0%)
dist/es.js 131 kB +137 B (0%)
dist/module.js 132 kB +137 B (0%)
ℹ️ View Unchanged
Filename Size
dist/exception-autocapture.js 12.2 kB
dist/recorder-v2.js 108 kB
dist/recorder.js 108 kB
dist/surveys-module-previews.js 57.2 kB
dist/surveys.js 58.8 kB

compressed-size-action

@neilkakkar
Copy link
Contributor

neilkakkar commented May 7, 2024

This probably belongs in the playground folder, unless that leads to some complications?

otherwise, LGTM, nice work! This should improve quality of devX here a huge amount :D

@jurajmajerik
Copy link
Contributor Author

Makes sense, moved to playground :)

Copy link
Contributor

@neilkakkar neilkakkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one pending comment, nice work! 🚀

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just need to delete this folder

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants