feat: Remotely enable heatmaps via decide #1154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Size Change: +1.79 kB (0%) Total Size: 976 kB
ℹ️ View Unchanged
|
pauldambra
reviewed
Apr 24, 2024
Comment on lines
+77
to
+79
| // store this in-memory in case persistence is disabled | ||
| this._enabledServerSide = optIn | ||
| this.startIfEnabled() |
There was a problem hiding this comment.
<attempted-nerd-snipe>was thinking this the last time I changed replay, we do this double storage in lots of places, would be so nice if "disabled persistence" was an in-memory store so we didn't need to track things outside of persistence</attempted-nerd-snipe>
There was a problem hiding this comment.
Hmmmmmmm it already is a memory store 🤔 Which is confusing... I wonder why we have this duplication...?
This was referenced May 20, 2024
This was referenced May 28, 2024
This was referenced Jun 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Client side component of PostHog/posthog#21807
Checklist