Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add a test #1144

Merged
merged 2 commits into from
Apr 17, 2024
Merged

chore: add a test #1144

merged 2 commits into from
Apr 17, 2024

Conversation

pauldambra
Copy link
Member

@pauldambra pauldambra commented Apr 17, 2024

context in https://posthog.slack.com/archives/C044P04L92T/p1712324149123769

a customer reported some call-to-action buttons aren't capturing text correctly.

the buttons have multiple children and I wanted to check we do handle that correctly, we do, but may as well keep the test to protect the behavoiur

@pauldambra pauldambra requested review from slshults and a team April 17, 2024 19:22
Copy link

github-actions bot commented Apr 17, 2024

Size Change: 0 B

Total Size: 962 kB

ℹ️ View Unchanged
Filename Size
dist/array.full.js 230 kB
dist/array.js 127 kB
dist/es.js 128 kB
dist/exception-autocapture.js 12.2 kB
dist/module.js 128 kB
dist/recorder-v2.js 108 kB
dist/recorder.js 108 kB
dist/surveys-module-previews.js 62 kB
dist/surveys.js 58.3 kB

compressed-size-action

@pauldambra pauldambra merged commit 08a80bb into main Apr 17, 2024
11 checks passed
@pauldambra pauldambra deleted the chore/add-a-test branch April 17, 2024 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants