Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Reacting to config changes #1138

Merged
merged 17 commits into from
Apr 17, 2024
Merged

fix: Reacting to config changes #1138

merged 17 commits into from
Apr 17, 2024

Conversation

benjackwhite
Copy link
Collaborator

@benjackwhite benjackwhite commented Apr 15, 2024

Changes

We enabled/ disable recordings due to config changes but not autocapture or surveys

  • Refactors the code so that each class is responsible for its own intialisation
  • Uses the nextjs example for consent driven dev

Checklist

  • Tests for new code (see advice on the tests we use)
  • Accounted for the impact of any changes across different browsers
  • Accounted for backwards compatibility of any changes (no breaking changes in posthog-js!)

Copy link

github-actions bot commented Apr 15, 2024

Size Change: +3.29 kB (0%)

Total Size: 961 kB

Filename Size Change
dist/array.full.js 230 kB +827 B (0%)
dist/array.js 127 kB +820 B (+1%)
dist/es.js 127 kB +820 B (+1%)
dist/module.js 128 kB +820 B (+1%)
ℹ️ View Unchanged
Filename Size
dist/exception-autocapture.js 12.2 kB
dist/recorder-v2.js 108 kB
dist/recorder.js 108 kB
dist/surveys-module-previews.js 62 kB
dist/surveys.js 58.3 kB

compressed-size-action

@benjackwhite benjackwhite requested a review from pauldambra April 15, 2024 16:14
@benjackwhite benjackwhite marked this pull request as ready for review April 15, 2024 16:14
@benjackwhite benjackwhite added the bump patch Bump patch version when this PR gets merged label Apr 15, 2024
Copy link
Member

@pauldambra pauldambra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could do with a cypress test (if they don't already exist and cover) to check things are really starting as expected but :shipit:

@pauldambra
Copy link
Member

Screenshot 2024-04-16 at 13 36 50

linters ftw 🤣

@benjackwhite benjackwhite requested a review from neilkakkar April 16, 2024 13:31
@benjackwhite benjackwhite added bump minor Bump minor version when this PR gets merged and removed bump patch Bump patch version when this PR gets merged labels Apr 17, 2024
@benjackwhite benjackwhite merged commit 4998648 into main Apr 17, 2024
11 checks passed
@benjackwhite benjackwhite deleted the fix/set_config_reactions branch April 17, 2024 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bump minor Bump minor version when this PR gets merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants