Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: patch rrweb zero width canvas bug #1075

Merged
merged 1 commit into from
Mar 12, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 22 additions & 5 deletions patches/rrweb@2.0.0-alpha.11.patch
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
diff --git a/es/rrweb/packages/rrweb/src/record/mutation.js b/es/rrweb/packages/rrweb/src/record/mutation.js
index 81ad4520d1435d088752a85f9a55a68ad6e0f514..39d96af4f65eb32ba13eb7d5a81076e996c9df26 100644
index 81ad4520d1435d088752a85f9a55a68ad6e0f514..e19dec6cc98ea782d53328853ca1b46d96e129f7 100644
--- a/es/rrweb/packages/rrweb/src/record/mutation.js
+++ b/es/rrweb/packages/rrweb/src/record/mutation.js
@@ -1,563 +1,607 @@
Expand Down Expand Up @@ -28,7 +28,7 @@ index 81ad4520d1435d088752a85f9a55a68ad6e0f514..39d96af4f65eb32ba13eb7d5a81076e9
+ isSerializedIframe,
+ isSerializedStylesheet,
+} from "../utils.js";

function isNodeInLinkedList(n) {
- return '__ln' in n;
+ return "__ln" in n;
Expand Down Expand Up @@ -1129,6 +1129,23 @@ index 81ad4520d1435d088752a85f9a55a68ad6e0f514..39d96af4f65eb32ba13eb7d5a81076e9
+ return true;
+ }
+ return _isAncestorInSet(set, parentNode);
}

export { MutationBuffer as default };
}

export { MutationBuffer as default };
diff --git a/es/rrweb/packages/rrweb/src/record/observers/canvas/canvas-manager.js b/es/rrweb/packages/rrweb/src/record/observers/canvas/canvas-manager.js
index 8746997c9b849ac5c952fdbe0a8dd608d6680a3a..534c6076f1cf63dfde972bb45991fc70694427b3 100644
--- a/es/rrweb/packages/rrweb/src/record/observers/canvas/canvas-manager.js
+++ b/es/rrweb/packages/rrweb/src/record/observers/canvas/canvas-manager.js
@@ -118,6 +118,12 @@ class CanvasManager {
context.clear(context.COLOR_BUFFER_BIT);
}
}
+
+ // The browser throws if the canvas is 0 in size
+ // Uncaught (in promise) DOMException: Failed to execute 'createImageBitmap' on 'Window': The source image width is 0.
+ // Assuming the same happens with height
+ if (canvas.width === 0 || canvas.height === 0) return;
+
const bitmap = yield createImageBitmap(canvas);
worker.postMessage({
id,
6 changes: 3 additions & 3 deletions pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading