-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: custom host with a path #290
Conversation
# Conflicts: # CHANGELOG.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lots of tests 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
left a suggestion but overall looks gooood
@ioannisj guessing I can close bcheidemann-kmbal#1 as this PR does (near enough) the same thing? EDIT: I see I raised the PR against a fork anyway 🙈 |
Hey @bcheidemann, so sorry! I completely missed that and didn't see a notification! That's a pity, cause it was looks like most (if not all) of the work was already done for this! Yeah, I think that the fact that it was not against this repo had something to do with it! Thank you for the effort and time though! ❤️ |
Hey, no problem! Very much my fault for not raising the PR against the right repo. TBH I'm glad to have another implementation of the same fix; reviewing it was a good learning opportunity for me 😉 |
* fix: custom host with a path * fix: test * fix: tests * fix: lint
💡 Motivation and Context
Closes #274
💚 How did you test it?
Added some unit tests
📝 Checklist