feat: load remote config and feature flags #283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ioannisj
commented
Jan 21, 2025
| @@ -217,4 +237,45 @@ class PostHogApi { | |||
| } | |||
| }.resume() | |||
| } | |||
|
|
|||
| func remoteConfig( | |||
There was a problem hiding this comment.
Call to new remote config endpoint
ioannisj
commented
Jan 21, 2025
Comment on lines
+64
to
+69
| #if os(iOS) | ||
| /// Enable mobile surveys | ||
| /// Experimental support | ||
| /// Default: false | ||
| @objc public var surveysEnabled: Bool = false | ||
| #endif |
There was a problem hiding this comment.
No functionality for now, just setting up the public api
ioannisj
commented
Jan 21, 2025
| // PostHog | ||
| // | ||
| // Created by Manoel Aranda Neto on 10.10.23. | ||
| // | ||
|
|
||
| import Foundation | ||
|
|
||
| class PostHogFeatureFlags { | ||
| class PostHogRemoteConfig { |
There was a problem hiding this comment.
Grouped config and feature flags in a single object here
ioannisj
commented
Jan 21, 2025
| } | ||
|
|
||
| private func preloadFeatureFlags() { | ||
| featureFlagsLock.withLock { |
There was a problem hiding this comment.
Not sure about this. I think we may need to move it in config.preloadFeatureFlags check below
ioannisj
commented
Jan 21, 2025
| let cachedFeatureFlags = featureFlagsLock.withLock { self.featureFlags } | ||
| let hasFeatureFlags = remoteConfig["hasFeatureFlags"] as? Bool == true | ||
| if hasFeatureFlags, cachedFeatureFlags == nil { | ||
| reloadFeatureFlags() |
There was a problem hiding this comment.
This is where we reload feature flags in case hasFeatureFlags is true, but flags are missing
marandaneto
reviewed
Jan 21, 2025
| return nil | ||
| } | ||
|
|
||
| let url = baseUrl.appendingPathComponent("/array/\(config.apiKey)/config") |
There was a problem hiding this comment.
I think we should fix #274 otherwise its one more place that this will fail
There was a problem hiding this comment.
True, I'll follow up with another PR to address that part
marandaneto
reviewed
Jan 21, 2025
marandaneto
reviewed
Jan 21, 2025
marandaneto
approved these changes
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💡 Motivation and Context
Building the foundation for mobile surveys. This is one part of many on the feature branch
feat/mobile-surveys.This adds remote config loading and caching on SDK
hasFeatureFlags. When this value is false, we can skip loading feature flags cause the team doesn't have any flags enabled.hasFeatureFlagsis true we make sure that flags are reloaded#skip-changelog
💚 How did you test it?
Modified and added some unit tests
📝 Checklist