fix: Events Queue is only paused if there were errors #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marandaneto
commented
Jan 10, 2024
| @@ -497,7 +497,7 @@ public class PostHog private constructor( | |||
| if (values.contains(value)) { | |||
| shouldSendFeatureFlagEvent = false | |||
| } else { | |||
| values.add(key) | |||
| values.add(value) | |||
There was a problem hiding this comment.
do not send feature flags called event twice test already exists and it was failing correctly
Instructions and example for changelogPlease add an entry to ## Next
- Events Queue is only paused if there were errors ([#78](https://github.com/PostHog/posthog-android/pull/78))If none of the above apply, you can opt out of this check by adding |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💡 Motivation and Context
The event Queue was paused even if there were no errors, so setting a lower
flushIntervalSecondsdid not have a lot of effects.The
Do not report flag events if the flag has been reported with the same valuefix part of this PR was found after fixing the main issue and was necessary to be in the same PR to make the CI happy.💚 How did you test it?
📝 Checklist