Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Check keyboard status during snapshot instead of using WindowInsets listener #77

Merged
merged 6 commits into from
Jan 11, 2024

Conversation

marandaneto
Copy link
Member

@marandaneto marandaneto commented Jan 10, 2024

💡 Motivation and Context

https://posthog.com/questions/status-bar-color-not-updating

I recall fixing something similar in the past as well.
Sometimes the new APIs (setOnApplyWindowInsetsListener) are not well documented on when and how to use them, this is just another weird corner case/side effect.

💚 How did you test it?

Testing the sample app with a different theme and status colors

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • I updated the docs if needed.
  • No breaking change or entry added to the changelog.

@marandaneto marandaneto requested a review from a team January 10, 2024 10:30
@marandaneto marandaneto marked this pull request as ready for review January 10, 2024 10:30
@marandaneto marandaneto changed the title fix: Check keyboard status during snapshot instead of using view list… fix: Check keyboard status during snapshot instead of using WindowInsets listener Jan 10, 2024
Copy link
Member

@pauldambra pauldambra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@marandaneto marandaneto merged commit 7735aca into main Jan 11, 2024
3 of 4 checks passed
@marandaneto marandaneto deleted the fix/statusbar-not-changing branch January 11, 2024 09:26
Copy link

Fails
🚫 Please consider adding a changelog entry for the next release.

Instructions and example for changelog

Please add an entry to CHANGELOG.md to the "Next" section. Make sure the entry includes this PR's number.
Example:

## Next
- Check keyboard status during snapshot instead of using WindowInsets listener ([#77](https://github.com/PostHog/posthog-android/pull/77))

If none of the above apply, you can opt out of this check by adding #skip-changelog to the PR description.

Generated by 🚫 dangerJS against 2b370c6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants