-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add referrer url automatically #186
add referrer url automatically #186
Conversation
@beradeep whats about if the |
posthog-android/src/main/java/com/posthog/android/internal/PostHogAndroidUtils.kt
Outdated
Show resolved
Hide resolved
posthog-android/src/main/java/com/posthog/android/internal/PostHogAndroidUtils.kt
Outdated
Show resolved
Hide resolved
I'm curious why do we need this? Is it for another prop like |
no, I am wondering if the app is opened via the browser, if we need to account for this intent name or not, maybe we should just ignore it, or maybe we should read from it as well since the docs isn't that clear when it's used. |
posthog-android/src/main/java/com/posthog/android/internal/PostHogAndroidUtils.kt
Outdated
Show resolved
Hide resolved
posthog-android/src/main/java/com/posthog/android/internal/PostHogAndroidUtils.kt
Outdated
Show resolved
Hide resolved
...id/src/main/java/com/posthog/android/internal/PostHogActivityLifecycleCallbackIntegration.kt
Outdated
Show resolved
Hide resolved
happy to approve and merge after checking out this comment, and thanks for the PR o/ |
don't forget about the changelog entry. |
i'm still not able to understand this. when the app is opened via a link from the browser, the deep link url and the referrer site does get read and captured from the intent built automatically by the Android system. i think you meant that you want to test this feature. am i right? |
@beradeep https://developer.android.com/reference/android/provider/Browser#EXTRA_APPLICATION_ID
Right now we don't do |
I don't think we need that here. This is only required when we need to get the name of the application calling the browser. Unless the client app is a browser app, I don't think we need that, do we? |
💡 Motivation and Context
#138
💚 How did you test it?
Added tests to include checks for
$referrer
and$referring_domain
properties in case of referrals from apps and websites.📝 Checklist