Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

recording: do not capture password text even if masking is off #111

Merged
merged 4 commits into from
Mar 8, 2024
Merged

recording: do not capture password text even if masking is off #111

merged 4 commits into from
Mar 8, 2024

Conversation

marandaneto
Copy link
Member

@marandaneto marandaneto commented Mar 8, 2024 •
edited
Loading

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • I updated the docs if needed.
  • No breaking change or entry added to the changelog.

@marandaneto marandaneto requested a review from a team March 8, 2024 13:02
pauldambra
pauldambra approved these changes Mar 8, 2024
View reviewed changes
Copy link
Member

@pauldambra pauldambra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@marandaneto marandaneto changed the title recording: do not capture password content even if mask is off recording: do not capture password text even if masking is off Mar 8, 2024
@marandaneto marandaneto marked this pull request as ready for review March 8, 2024 14:14
@marandaneto marandaneto merged commit 9f12f26 into main Mar 8, 2024
6 checks passed
@marandaneto marandaneto deleted the fix/no-password-content branch March 8, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pauldambra pauldambra pauldambra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marandaneto @pauldambra