Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix merge groups for events #105

Merged
merged 2 commits into from
Feb 29, 2024
Merged

fix merge groups for events #105

merged 2 commits into from
Feb 29, 2024

Conversation

marandaneto
Copy link
Member

@marandaneto marandaneto commented Feb 28, 2024

💡 Motivation and Context

$groups were only sent if you were capturing events with groupProperties.
bug found by @Lior539

💚 How did you test it?

unit test.

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • I updated the docs if needed.
  • No breaking change or entry added to the changelog.

@marandaneto marandaneto requested review from a team and Lior539 February 28, 2024 13:20
var reloadFeatureFlags = false

groups?.let {
val currentKey = it[type]
synchronized(groupsLock) {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we read and set, we need an atomic operation

@marandaneto marandaneto merged commit 1163aea into main Feb 29, 2024
5 checks passed
@marandaneto marandaneto deleted the fix/merge-groups branch February 29, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants