Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add new implementation for "reduce_dimension" process #94

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

MichaelBrueggemann
Copy link
Contributor

What

This new implementation of reduce_dimension provides some new Features:

  • are cleaner layout of the code
  • support for adding "custom reducer functions". This approache uses "eval()/parse()" in combination with the "Blacklist"-approach suggested in Safety Issue with "run_udf"!!! #81. This allows users to give their own reducer functions beyond the scope of pre-defined reducers.
    • This also is a work-around for gdalcubes current implementation of reduce_time() as it's not possible to rename the bands of the new cube created by this process if you use a pre-defined reducer
  • now only "time" is supported as an argument for declaring a temporal reduction (instead of also supporting "t") to make the function more understandable
  • it adds the option to keep bands that are included in the datacube before calling this process

Suggestion

I also suggest to move the implemtion of this function for the argument "bands" into it's own function, as it's confusing on whats the purpose of the function reduce_dimension.

@MichaelBrueggemann MichaelBrueggemann changed the base branch from main to develop February 9, 2024 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant