Icpflutter 1242

.github/CODEOWNERS

@@ -1 +1 @@
-*       @krystofwoldrich @stefanosiano @buenaflor
+*       @krystofwoldrich @stefanosiano @buenaflor @martinhaintz

.github/workflows/analyze.yml

@@ -51,6 +51,11 @@ jobs:
 
       - run: dart doc --dry-run
 
+      - name: Run publish validation
+        run: |
+          dart pub get --directory ../scripts/publish_validation
+          dart run ../scripts/publish_validation/bin/publish_validation.dart --executable ${{ inputs.sdk }}
+
   package-analysis:
     # `axel-op/dart-package-analyzer` is using `flutter pub upgrade` instead of `get`,
     # which ignores pubspec.yaml `dependency_overrides`. Because of that, all `release/*` branches are failing,

.github/workflows/flutter.yml

@@ -29,6 +29,7 @@ jobs:
     defaults:
       run:
         shell: bash
+        working-directory: flutter
     strategy:
       fail-fast: false
       matrix:
@@ -77,21 +78,23 @@ jobs:
       - run: flutter upgrade
 
       - name: Pub Get
-        run: |
-          cd flutter
-          flutter pub get
+        run: flutter pub get
 
-      - name: Test chrome
+      - name: Test web (JS)
         if: matrix.target == 'web'
         run: |
-          cd flutter
           flutter test --platform chrome --test-randomize-ordering-seed=random --exclude-tags canvasKit
           flutter test --platform chrome --test-randomize-ordering-seed=random --tags canvasKit --web-renderer canvaskit
 
+      - name: Test web (WASM)
+        if: matrix.target == 'web'
+        run: |
+          flutter test --platform chrome --wasm --test-randomize-ordering-seed=random --exclude-tags canvasKit
+          flutter test --platform chrome --wasm --test-randomize-ordering-seed=random --tags canvasKit --web-renderer canvaskit
+
       - name: Test VM with coverage
         if: matrix.target == 'linux' || matrix.target == 'macos' || matrix.target == 'windows'
         run: |
-          cd flutter
           flutter test --coverage --test-randomize-ordering-seed=random
           dart run remove_from_coverage -f coverage/lcov.info -r 'binding.dart'
 
@@ -111,11 +114,11 @@ jobs:
           exclude: 'lib/src/native/cocoa/binding.dart'
 
       - name: Build ${{ matrix.target }}
+        working-directory: flutter/example
         run: |
           flutter config --enable-windows-desktop
           flutter config --enable-macos-desktop
           flutter config --enable-linux-desktop
-          cd flutter/example
           TARGET=${{ matrix.target }}
           flutter pub get
           case $TARGET in
@@ -179,7 +182,7 @@ jobs:
       - uses: actions/checkout@v4
 
       - name: ktlint
-        uses: ScaCap/action-ktlint@7bfa4928cf705b83700c91fecc0e1a3a4c0e99ad # pin@1.8.3
+        uses: ScaCap/action-ktlint@26c5e9b625966139d9956cbbb6217375480d4e14 # pin@1.9.0
         with:
           github_token: ${{ secrets.github_token }}
           reporter: github-pr-review
@@ -192,6 +195,6 @@ jobs:
     steps:
       - uses: actions/checkout@v4
       # To recreate baseline run: detekt -i flutter/android,flutter/example/android -b flutter/config/detekt-bl.xml -cb
-      - uses: natiginfo/action-detekt-all@b9daaf58ff7a4885ff92ba612c3ea72bf1abeadb # pin@1.23.6
+      - uses: natiginfo/action-detekt-all@6bf4342ea96f638ecced05cf7d7dc48acdecc854 # pin@1.23.7
         with:
           args: -i flutter/android,flutter/example/android --baseline flutter/config/detekt-bl.xml --jvm-target 1.8 --build-upon-default-config --all-rules

.github/workflows/flutter_integration_test.yml

@@ -49,7 +49,7 @@ jobs:
         run: flutter pub get
 
       - name: Gradle cache
-        uses: gradle/gradle-build-action@66535aaf56f831b35e3a8481c9c99b665b84dd45 # pin@v3.4.2
+        uses: gradle/gradle-build-action@ac2d340dc04d9e1113182899e983b5400c17cda1 # pin@v3.5.0
 
       - name: AVD cache
         uses: actions/cache@v4
@@ -62,7 +62,7 @@ jobs:
 
       - name: create AVD and generate snapshot for caching
         if: steps.avd-cache.outputs.cache-hit != 'true'
-        uses: reactivecircus/android-emulator-runner@77986be26589807b8ebab3fde7bbf5c60dabec32 #pin@v2.31.0
+        uses: reactivecircus/android-emulator-runner@f0d1ed2dcad93c7479e8b2f2226c83af54494915 #pin@v2.32.0
         with:
           working-directory: ./flutter/example
           api-level: 21
@@ -74,7 +74,7 @@ jobs:
           script: echo 'Generated AVD snapshot for caching.'
 
       - name: launch android emulator & run android integration test
-        uses: reactivecircus/android-emulator-runner@77986be26589807b8ebab3fde7bbf5c60dabec32 #pin@v2.31.0
+        uses: reactivecircus/android-emulator-runner@f0d1ed2dcad93c7479e8b2f2226c83af54494915 #pin@v2.32.0
         with:
           working-directory: ./flutter/example
           api-level: 21

.github/workflows/flutter_test.yml

@@ -54,7 +54,7 @@ jobs:
         run: flutter pub get
 
       - name: Gradle cache
-        uses: gradle/gradle-build-action@66535aaf56f831b35e3a8481c9c99b665b84dd45 # pin@v3.0.0
+        uses: gradle/gradle-build-action@ac2d340dc04d9e1113182899e983b5400c17cda1 # pin@v3.0.0
 
       - name: AVD cache
         uses: actions/cache@v4
@@ -67,7 +67,7 @@ jobs:
 
       - name: create AVD and generate snapshot for caching
         if: steps.avd-cache.outputs.cache-hit != 'true'
-        uses: reactivecircus/android-emulator-runner@77986be26589807b8ebab3fde7bbf5c60dabec32 #pin@v2.31.0
+        uses: reactivecircus/android-emulator-runner@f0d1ed2dcad93c7479e8b2f2226c83af54494915 #pin@v2.32.0
         with:
           working-directory: ./flutter/example
           api-level: 31
@@ -84,7 +84,7 @@ jobs:
         run: flutter build apk --debug
 
       - name: launch android emulator & run android native test
-        uses: reactivecircus/android-emulator-runner@77986be26589807b8ebab3fde7bbf5c60dabec32 #pin@v2.31.0
+        uses: reactivecircus/android-emulator-runner@f0d1ed2dcad93c7479e8b2f2226c83af54494915 #pin@v2.32.0
         with:
           working-directory: ./flutter/example/android
           api-level: 31
@@ -97,7 +97,7 @@ jobs:
           script: ./gradlew testDebugUnitTest
 
       - name: launch android emulator & run android integration test
-        uses: reactivecircus/android-emulator-runner@77986be26589807b8ebab3fde7bbf5c60dabec32 #pin@v2.31.0
+        uses: reactivecircus/android-emulator-runner@f0d1ed2dcad93c7479e8b2f2226c83af54494915 #pin@v2.32.0
         with:
           working-directory: ./flutter/example
           api-level: 31

.github/workflows/testflight.yml

@@ -16,7 +16,7 @@ jobs:
       - uses: actions/checkout@v4
       - uses: subosito/flutter-action@44ac965b96f18d999802d4b807e3256d5a3f9fa1 # pin@v2.16.0
       - run: xcodes select 15.0.1
-      - uses: ruby/setup-ruby@3a77c29278ae80936b4cb030fefc7d21c96c786f # pin@v1.185.0
+      - uses: ruby/setup-ruby@a6b46b8a08edb18935835849f2a17072d5cc8c73 # pin@v1.192.0
         with:
           ruby-version: '2.7.5'
           bundler-cache: true

.github/workflows/update-deps.yml

@@ -33,6 +33,7 @@ jobs:
       path: metrics/flutter.properties
       name: Flutter SDK (metrics)
       changelog-entry: false
+      pr-strategy: update
     secrets:
       api-token: ${{ secrets.CI_DEPLOY_KEY }}
 
@@ -42,5 +43,6 @@ jobs:
       path: scripts/update-symbol-collector.sh
       name: Symbol collector CLI
       changelog-entry: false
+      pr-strategy: update
     secrets:
       api-token: ${{ secrets.CI_DEPLOY_KEY }}