This repository has been archived by the owner on Dec 19, 2024. It is now read-only.
Add global-only RTL mirroring. #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e111077
suggested changes
Aug 29, 2017
| var globalElement = | ||
| (document.body && document.body.hasAttribute('dir')) | ||
| ? document.body | ||
| : document.documentElement; |
There was a problem hiding this comment.
is documentElement ever null?
There was a problem hiding this comment.
is it html? the og comment promised we also look at html
There was a problem hiding this comment.
document.documentElement is the <HTML> node and should never be null in any reasonable circumstance AFAIK.
notwaldorf
reviewed
Aug 29, 2017
| * html elements (measured on document.body or document.documentElement as | ||
| * available). | ||
| */ | ||
| useGlobalRtlAttribute: { |
There was a problem hiding this comment.
uhhh maybe RTL to match __targetIsRT? 🚲🏡
There was a problem hiding this comment.
Can you spell that as an attribute for me? :)
notwaldorf
reviewed
Aug 29, 2017
|
|
||
| suite('and dir="rtl" on <html>', function() { | ||
| setup(function() { | ||
| document.documentElement.setAttribute('dir', 'rtl'); |
There was a problem hiding this comment.
maybe call out html explicitly? is there a document.html or am i smoking crack?
There was a problem hiding this comment.
e111077
approved these changes
Aug 30, 2017
|
Is this considered solving #57? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RTL detection based on CSS styles in subtrees has timing issues. In some circumstances, the value of the
directionstyle property will be empty string while an element is booting up even though it should probably read as"rtl".This change proposes a fix where an addition configuration (
use-global-rtl-attribute) of the iconset tells it to use the value of thedirattribute on either<body>or<html>, whichever is available.Fixes #64