Data should be reset when the pattern no longer matches.

PolymerElements · Dec 12, 2017 · 4b8e49e · 4b8e49e
1 parent 951dc29
commit 4b8e49e
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/app-route.html b/app-route.html
@@ -237,6 +237,7 @@
       __resetProperties: function() {
         this._setActive(false);
         this._matched = null;
+	this.data = {};
       },
 
       __tryToMatch: function() {

diff --git a/test/app-route.html b/test/app-route.html
@@ -169,13 +169,13 @@
 
       route.pattern = '/user/:username/likes/:count';
 
-      // At the moment, we don't reset data when we no longer match.
-      expect(route.data).to.be.deep.equal({username: 'sans'});
+      // The data should reset when we no longer match.
+      expect(route.data).to.be.deep.equal({});
       expect(route.active).to.be.equal(false);
 
       route.set('route.path', "/does/not/match");
 
-      expect(route.data).to.be.deep.equal({username: 'sans'});
+      expect(route.data).to.be.deep.equal({});
       expect(route.active).to.be.equal(false);
 
       route.set('route.path', '/user/undyne/likes/20');