Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix gradle buildscript for releases #9

Merged

Conversation

solonovamax
Copy link
Member

@solonovamax solonovamax commented Mar 1, 2025

If you edit the tectonic-common.gradle.kts, then it's applied to all projects.

Currently, I have configured it to publish artifacts with the following names:

  • com.dfsek.tectonic:common
  • com.dfsek.tectonic:hocon
  • com.dfsek.tectonic:json
  • com.dfsek.tectonic:toml
  • com.dfsek.tectonic:yaml

if you want me to switch it to use tectonic-hocon instead of tectonic-lang-hocon, that can be easily done as well.

@duplexsystem
Copy link
Member

Currently things are setup as com.dfsek.tectonic:hocon for example, if that formatting can be used I would prefer that but otherwise, I'd prefer tectonic-hocon over tectonic-lang-hocon

@solonovamax
Copy link
Member Author

Currently things are setup as com.dfsek.tectonic:hocon for example

you had previously changed everything to publish under com.dfsek:tectonic, which is why I went with that naming.

the previous behaviour before the change was to use com.dfsek.tectonic:hocon, so I can easily revert to that.

@duplexsystem
Copy link
Member

Currently things are setup as com.dfsek.tectonic:hocon for example

you had previously changed everything to publish under com.dfsek:tectonic, which is why I went with that naming.

the previous behaviour before the change was to use com.dfsek.tectonic:hocon, so I can easily revert to that.

Ah sorry I must have made a mistake, my bad, thanks for catching that :)

@solonovamax
Copy link
Member Author

Alright, I'll revert my changes and go back to the old behaviour before your change

@duplexsystem
Copy link
Member

Ah I understand what happened now. TYSM! merging once gha is done

@duplexsystem duplexsystem merged commit 0470a2d into PolyhedralDev:master Mar 2, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants