Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setup basic CI checks #10

Merged
merged 5 commits into from
Jun 13, 2023
Merged

setup basic CI checks #10

merged 5 commits into from
Jun 13, 2023

Conversation

fbielejec
Copy link
Contributor

@fbielejec fbielejec commented Jun 12, 2023

  • add clippy checks, fix all clippy warnings
  • add toolchain file to set same rustc for all (set it to stable but happy to change)
  • add fmt file with basic formatting options
  • run fmt --all
  • basic CI with caching, branch protection rules

@fbielejec fbielejec requested a review from JoshOrndorff June 12, 2023 08:22
@notlesh
Copy link
Contributor

notlesh commented Jun 12, 2023

This would probably cause a lot of conflicts with #9, could we run this once that is merged?

@fbielejec
Copy link
Contributor Author

fbielejec commented Jun 13, 2023

This would probably cause a lot of conflicts with #9, could we run this once that is merged?

You could just format that PR after a merge and resolve to yours?

@fbielejec fbielejec changed the title use standard Rust formatting setup basic CI checks Jun 13, 2023
@fbielejec
Copy link
Contributor Author

I created a basic action together with branch protection rules but I cannot set them, as we have a private repo on a free plan:
2023-06-13-1686647728_screenshot_2560x1600

The easiest would be to just turn it public, are there any reasons to keep it hidden @JoshOrndorff @notlesh WYT?

Copy link
Collaborator

@JoshOrndorff JoshOrndorff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent thank you!

Regarding making the repo public, I fully support it. I am actively advocating for making the entire academy content public. I haven't yet succeeded in convincing the admins to do that, so I guess it is up to @nukemandan to decide if we can make this repo public.

There is really nothing private in here at all. There aren't even instructions for what we will do in class. It is just a Substrate node. So I hope we can open it.

In any case, feel free to merge this when you are ready.

@JoshOrndorff
Copy link
Collaborator

Yeah, let's not hold this up. I can own the process of resolving it with #9.

@fbielejec
Copy link
Contributor Author

Yeah, let's not hold this up. I can own the process of resolving it with #9.

you have my axe if help needed. ok merging

@fbielejec fbielejec merged commit 21658a3 into main Jun 13, 2023
@fbielejec fbielejec deleted the fmt-all branch June 13, 2023 14:36
@notlesh notlesh mentioned this pull request Jun 13, 2023
8 tasks
@JoshOrndorff JoshOrndorff mentioned this pull request Jun 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants