Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What to do about disabled variants? #5

Closed
PokeJofeJr4th opened this issue Jun 25, 2023 · 0 comments
Closed

What to do about disabled variants? #5

PokeJofeJr4th opened this issue Jun 25, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@PokeJofeJr4th
Copy link
Owner

PokeJofeJr4th commented Jun 25, 2023

With the original implementation, disabled variants are completely ignored during code generation. This meant that in a match statement, the disabled variant was not covered, preventing the code from being compiled. I see three options:

  1. Ignore the disabled flag
  2. Panic when a disabled variant is passed in
  3. Return an Option or Result when a disabled variant could be passed in

Number 2 is currently implemented

@PokeJofeJr4th PokeJofeJr4th added the bug Something isn't working label Jun 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant