Skip to content

Commit

Permalink
Fix[MCDL]: should dismiss download list view before alerting
Browse files Browse the repository at this point in the history
A lot of users have been unable to proceed past 100% download, mostly
after fully downloading will get it stuck at 1 byte. I have no idea if
it fixes the issue, but it does 2 things:
- Dismiss download list view if it's visible, otherwise the JIT alert
will not he shown
- Change the progress string to Waiting for JIT after completing
download
  • Loading branch information
khanhduytran0 committed Aug 2, 2024
1 parent d4f53b3 commit aafdeaf
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion Natives/LauncherNavigationController.m
Original file line number Diff line number Diff line change
Expand Up @@ -326,6 +326,7 @@ - (void)observeValueForKeyPath:(NSString *)keyPath ofObject:(id)object change:(N
self.progressText.text = progress.localizedAdditionalDescription;

if (!progress.finished) return;
[self.progressVC dismissModalViewControllerAnimated:NO];

self.progressViewMain.observedProgress = nil;
if (self.task.metadata) {
Expand Down Expand Up @@ -385,7 +386,7 @@ - (void)invokeAfterJITEnabled:(void(^)(void))handler {
return;
}

//CADisplayLink *displayLink = [CADisplayLink displayLinkWithTarget:self selector:@selector(tickJIT)];
self.progressText.text = localize(@"launcher.wait_jit.title", nil);

UIAlertController* alert = [UIAlertController alertControllerWithTitle:localize(@"launcher.wait_jit.title", nil)
message:hasTrollStoreJIT ? localize(@"launcher.wait_jit_trollstore.message", nil) : localize(@"launcher.wait_jit.message", nil)
Expand Down

0 comments on commit aafdeaf

Please sign in to comment.