-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release : 2.15.3 #3355
Open
jacquesfize
wants to merge
18
commits into
develop
Choose a base branch
from
release-2-15-3
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Release : 2.15.3 #3355
+489
−372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3355 +/- ##
===========================================
- Coverage 84.00% 83.95% -0.06%
===========================================
Files 122 122
Lines 9736 9748 +12
===========================================
+ Hits 8179 8184 +5
- Misses 1557 1564 +7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
cd2198c
to
b24b22c
Compare
For Synthese queries involving blurring: - Add first order_by on descending date_min > this allows to retrieve up-to-50000 more-recently-dated observations from the up-to-100000 observations of the 2 unioned queries - Set (now) second order_by on id_synthese from ascending to descending > this allows, for several observations with same date_min, to prioritize more-recently-added-in-database observations Notes: - We want to preserve the final order_by on `allowed_geom_cte.c.priority` and the distinct clause on id_synthese, to keep only precise geom for obs retrieved in both precise and blurred subqueries: this requires to: - Keep the order_by on id_synthese - The wish to retrieve "more recent" observations may be understood in two ways: - Meant as "more-recently-dated": operated by the first order_by > it is thus assumed this is the preferred meaning given to "more recent" - Meant as "more-recently-added-in-database": operated by the second order_by > it is thus assumed that for two observations with the same date_min we qualify as "more recent" the one with the greater id_synthese Solves #3249 Co-authored-by: VincentCauchois <vincent.cauchois@mnhn.fr> Co-authored-by: Christophe Ramet <christophe.ramet@mnhn.fr>
f6ccdd1
to
e2809e6
Compare
…based on config value API_ENDPOINT
15 tasks
* fix(synthese): area filters in the synthese verify SRID coherence --------- Co-authored-by: Jbrieuc LP <15981479+jbrieuclp@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist :
setup.py
if necessaryrequirements-dev
andrequirements