Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove app.config.ts and associated commands #2748

Merged
merged 2 commits into from
Oct 12, 2023
Merged

Remove app.config.ts and associated commands #2748

merged 2 commits into from
Oct 12, 2023

Conversation

jacquesfize
Copy link
Contributor

@jacquesfize jacquesfize commented Oct 11, 2023 •
edited
Loading

Suppression de la génération du fichier app.config.ts (dans le frontend). Lié à l'issue : #2747

TheoLechemia
TheoLechemia reviewed Oct 11, 2023
View reviewed changes
install/install_all/install_all.ini Outdated
@@ -8,7 +8,7 @@ mode=prod
my_local=fr_FR.UTF-8

# My host URL or IP, starting with http and with / at the end
my_url=http://mon.domaine.com/
my_url=http://127.0.0.1/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Attention, tu as poussé des choses pas lié à la PR

TheoLechemia
TheoLechemia reviewed Oct 11, 2023
View reviewed changes
test.py Outdated
@@ -0,0 +1,20 @@
SQLALCHEMY_DATABASE_URI = "postgresql://geonatadmin:adminadmin@localhost:5432/geonature2db"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Idem

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oui j'ai vu, j'ai cliqué trop vite dans vscode et il a push tous les fichiers modifiés..

@codecov
Copy link

codecov bot commented Oct 11, 2023 •
edited
Loading

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Files Coverage Δ
backend/geonature/app.py 77.23% <100.00%> (ø)
backend/geonature/core/command/main.py 0.00% <ø> (ø)
backend/geonature/core/gn_meta/models.py 93.45% <100.00%> (ø)
backend/geonature/core/gn_meta/routes.py 77.72% <100.00%> (ø)
backend/geonature/core/gn_synthese/models.py 86.95% <100.00%> (ø)
backend/geonature/core/gn_synthese/routes.py 87.27% <ø> (ø)
...nature/core/gn_synthese/utils/query_select_sqla.py 76.62% <100.00%> (ø)
backend/geonature/utils/command.py 0.00% <ø> (ø)
backend/geonature/utils/config_schema.py 92.83% <100.00%> (ø)
backend/geonature/celery_app.py 0.00% <0.00%> (ø)
... and 2 more

... and 1 file with indirect coverage changes

📢 Thoughts on this report? Let us know!.

@jacquesfize jacquesfize changed the title first comment appearance of app.config.ts + delete command associated… Remove app.config.ts and associated commands Oct 11, 2023
@jacquesfize jacquesfize force-pushed the delete-app-config-ts-frontend branch from fcf225c to 418e1d9 Compare October 11, 2023 13:57
@jacquesfize jacquesfize marked this pull request as ready for review October 11, 2023 14:17
@jacquesfize jacquesfize merged commit f7e973c into develop Oct 12, 2023
@jacquesfize jacquesfize deleted the delete-app-config-ts-frontend branch October 12, 2023 07:15
@camillemonchicourt camillemonchicourt mentioned this pull request Oct 17, 2023
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheoLechemia TheoLechemia TheoLechemia approved these changes

@bouttier bouttier Awaiting requested review from bouttier

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jacquesfize @TheoLechemia