CORE: Various reactivity & race condition fixes

lerna.json

@@ -1,4 +1,5 @@
 {
+  "version": "1.2.0",
   "npmClient": "yarn",
   "useWorkspaces": true,
   "packages": [
@@ -16,6 +17,5 @@
       ],
       "registry": "https://registry.npmjs.org/"
     }
-  },
-  "version": "1.2.0"
+  }
 }

packages/plexus-core/src/computed.ts

@@ -13,6 +13,7 @@ export class ComputedStateInstance<ValueType extends PlexusStateType = any> exte
 		// utilizing maps because it allows us to preform a lookup in O(1)
 		_depsDestroyers: Map<Dependency, ReturnType<WatchableMutable<any>["watch"]>>
 		_deps: Set<WatchableMutable<any>>
+		_ready: boolean
 	}
 	private instance: () => PlexusInstance
 	private computeFn: () => ValueType
@@ -41,6 +42,7 @@ export class ComputedStateInstance<ValueType extends PlexusStateType = any> exte
 			// utilizing maps because it allows us to preform a lookup in O(1)
 			_depsDestroyers: new Map<Dependency, ReturnType<WatchableMutable["watch"]>>(),
 			_deps: new Set(deps),
+			_ready: false,
 		}
 		this.refreshDeps()
 
@@ -51,8 +53,11 @@ export class ComputedStateInstance<ValueType extends PlexusStateType = any> exte
 		if (!this.instance()._computedStates.has(this)) {
 			this.instance().runtime.log("info", `Hoisting computed state ${this.id} with value`, this.value, ` to instance`)
 			this.instance()._computedStates.add(this)
-			// this.instance().storage?.sync()
+			this.instance().storage?.sync()
 		}
+		if (this._internalStore._ready) return
+		this._internalStore._ready = true
+		this.instance().runtime.log("info", `Computed state ${this.id} is ready`)
 	}
 	/**
 	 *  Internal Helper Function; for each dependency, add a watcher to the state that will update the computed state when a dependency changes

packages/plexus-core/src/state.ts

@@ -72,6 +72,10 @@ export class StateInstance<StateValue extends PlexusStateType> extends Watchable
 				this.instance().storage?.sync()
 			}
 		}
+		if (this._internalStore._ready) return
+		this._internalStore._ready = true
+		this.instance().runtime.log("info", `State ${this.id} is ready`)
+		// this.instance().runtime.broadcast(this.id, this._watchableStore._value)
 	}
 	/**
 	 * Set the value of the state
@@ -99,9 +103,9 @@ export class StateInstance<StateValue extends PlexusStateType> extends Watchable
 		// update the runtime conductor
 		// if (this._internalStore._persist) this.instance().storage?.set(this._internalStore._name, this._internalStore._value)
 		// this.instance().runtime.broadcast(this._internalStore._internalId, value)
-		this.mount()
 		super.set(value)
 		if (this._internalStore._persist) this.instance().storage?.set(this._internalStore._name, this._watchableStore._value)
+		// if (!this._internalStore._ready) this.mount()
 		// this.instance().runtime.broadcast(this.id, value)
 
 		return this
@@ -236,16 +240,15 @@ export class StateInstance<StateValue extends PlexusStateType> extends Watchable
 		this.instance().runtime.log("debug", `Accessing Stateful value ${this.instanceId}${this._internalStore._persist ? "; Persist Enabled" : ""}`)
 		this.mount()
 
-		if (this._internalStore._persist) {
-			const val = this.instance().storage?.get(this._internalStore._name)
-			if (super.value && isEqual(val, super.value)) {
-				this.instance().runtime.log("debug", `Stateful value ${this.instanceId} is equal to persisted value`) 
-			}
-			else{
-				this.instance().runtime.log("debug", `Stateful value ${this.instanceId} is not equal to persisted value`) 
-				this.set(val)
-			}
-		}
+		// if (this._internalStore._persist) {
+		// 	const val = this.instance().storage?.get(this._internalStore._name)
+		// 	if (super.value && isEqual(val, super.value)) {
+		// 		this.instance().runtime.log("debug", `Stateful value ${this.instanceId} is equal to persisted value`)
+		// 	} else {
+		// 		this.instance().runtime.log("debug", `Stateful value ${this.instanceId} is not equal to persisted value`)
+		// 		this.set(val)
+		// 	}
+		// }
 
 		// return deepClone(this._internalStore._value)
 		// return this._internalStore._publicValue