Add rudimentary HTTPS support #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jvyden
requested changes
Jul 9, 2024
jvyden
requested changes
Jul 11, 2024
There was a problem hiding this comment.
The only thing I would add to this is the ability for Bunkum to reload the SSL certificate without a restart, probably through a FS watch or something. This isn't strictly necessary so it can be addressed later.
But also GitHub workflows need to be updated to publish the new packages
jvyden
approved these changes
Jul 11, 2024
|
seem leg |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now there's a lot of hard-coded options which need to be moved into the config, such as enabled SSL protocols and enabled cipher suites. However this should do everything we need for the meantime.
I've placed TODOs on the things which need to be made configurable.