Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable QRMs as concrete solutions for augmentation and behavioral patterns #157

Merged
merged 76 commits into from
May 17, 2024
Merged

Enable QRMs as concrete solutions for augmentation and behavioral patterns #157

merged 76 commits into from
May 17, 2024

Conversation

wederbn
Copy link
Collaborator

@wederbn wederbn commented May 14, 2024

No description provided.

wederbn added 23 commits May 14, 2024 12:30
@wederbn
Improve logs in pattern transformator
67ea278
@wederbn
Remove unused code
598e41d
@wederbn
Inline pattern declaration
d54bf7f
@wederbn
Add missing variable declaration
137ae8d
@wederbn
Move pattern removal to utils
ee976fc
@wederbn
Add docs
2d60ba1
@wederbn
Fix linting
57bdfab
@wederbn
Remove unused code
66e24fa
@wederbn
Add utility function to retrieve types in a generic manner
34a73c5
@wederbn
Add utility method to check for QuantME subprocesses
583aed0
@wederbn
Remove redundant code
cd4b74b
@wederbn
Improve logging
728ee15
@wederbn
Simplify check for forbidden patterns
1a0aa84
@wederbn
Add constant for pattern prefix
96220b1
@wederbn
Switch to direct import
d1a2df2
@wederbn
Fix headings
d57eecd
@wederbn
Add PatternId to pattern modeling constructs
65c31a9
@wederbn
Incorporate pattern ID when adding pattern modeling constructs for se…
b415439 
…lected patterns
@wederbn
Forward pattern ID during transformation
fbcc971
@wederbn
Remove faulty logging
882a5b8
@wederbn
Retrieve pattern ID by type
d902210
@wederbn
Add IDs to test
47a04de
@wederbn
Add QC atlas to test setup
13ed40d
@wederbn
Copy link
Collaborator Author

wederbn commented May 14, 2024 •
edited by mbeisel
Loading

  • Add QC Atlas to test setup
  • Add initialized DB to test setup
  • Add fixed versions to test setup
  • Retrieve solutions and extract detectors during pattern transformation
  • Retrieve QRMs from solutions during QRM update
  • Extend pattern test to perform QuantME transformation using QRMs from solutions

@wederbn
Copy link
Collaborator Author

wederbn commented May 14, 2024

Solves #158 and contributes to #85

@wederbn wederbn marked this pull request as ready for review May 17, 2024 10:10
@wederbn wederbn requested a review from LaviniaStiliadou May 17, 2024 13:39
LaviniaStiliadou
LaviniaStiliadou approved these changes May 17, 2024
View reviewed changes
Copy link
Contributor

@LaviniaStiliadou LaviniaStiliadou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work!

@LaviniaStiliadou LaviniaStiliadou merged commit 5d53924 into master May 17, 2024
2 checks passed
@LaviniaStiliadou LaviniaStiliadou deleted the improveLogging branch May 17, 2024 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LaviniaStiliadou LaviniaStiliadou LaviniaStiliadou approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wederbn @LaviniaStiliadou @mbeisel