Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: s3 cache #3

Merged
merged 3 commits into from
May 13, 2024
Merged

feat: s3 cache #3

merged 3 commits into from
May 13, 2024

Conversation

kevinchen-pimq
Copy link

Description

combine changes, rebase onto v4

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (add or update README or docs)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

KeithYeh
KeithYeh reviewed May 13, 2024
View reviewed changes
Copy link
Member

@KeithYeh KeithYeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

用一個 poc workflow 測試一下

@kevinchen-pimq @KeithYeh
Update README.md
d6e6aff 
Co-authored-by: Keith Yeh <keithyehtw@gmail.com>
@kevinchen-pimq kevinchen-pimq requested a review from KeithYeh May 13, 2024 08:16
@KeithYeh KeithYeh merged commit 724fbe2 into Pisolutions-consultant:v4 May 13, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KeithYeh KeithYeh KeithYeh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kevinchen-pimq @KeithYeh