-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(pd): adjust trigger for branch release-6.5-20241101-v6.5.7 #3203
feat(pd): adjust trigger for branch release-6.5-20241101-v6.5.7 #3203
Conversation
Based on the PR title and description, it seems that the change is related to adjusting the trigger for a specific hotfix branch
Here are some suggestions to fix these potential problems:
Overall, it seems like a straightforward change, but it's important to make sure that it doesn't introduce any new issues or conflicts. |
Based on the PR title and description, it seems that this PR is making changes to the trigger for a specific hotfix branch There don't appear to be any potential problems with this change. However, it might be helpful to ensure that the correct version of Go is being used for the hotfix branch, as mentioned in the PR description. As a fixing suggestion, it might be helpful to add a comment in the code indicating that the trigger for the hotfix branch has been adjusted to use the correct Go version. Additionally, it might be helpful to mention the reason for the change in the comment as well. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: wuhuizuo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
Hotfix branch release-6.5-20241101-v6.5.7 need go1.23, change trigger to use correct go version.