Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: disable auto refresh cache image for master&8.4 #3184

Conversation

purelind
Copy link
Collaborator

Since 8.4, the base image has been switched from centos7 to rocky8, so we no longer use this task for cache image updates on branch master and 8.4.

@ti-chi-bot ti-chi-bot bot requested a review from wuhuizuo October 28, 2024 06:37
Copy link

ti-chi-bot bot commented Oct 28, 2024

I have already done a preliminary review for you, and I hope to help you do a better job.

Based on the pull request title and description, it seems that the changes are related to disabling the auto-refresh cache image for the master and 8.4 branches. The diff shows that the changes involve removing the build_branch() calls for the master and release-8.4 branches.

There are no immediate potential problems that I can see with this PR. However, it's important to ensure that the cache image is being updated properly for other branches.

As for fixing suggestions, it would be helpful to add a comment explaining the reason for disabling the auto-refresh cache image for the master and 8.4 branches. Additionally, it may be a good idea to make sure that there are no other branches that also need to have auto-refresh disabled.

Overall, this seems like a reasonable change that should not cause any issues for the pipeline.

Copy link

ti-chi-bot bot commented Oct 28, 2024

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot merged commit 5f9cd36 into PingCAP-QE:main Oct 28, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant