Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: temporary disable failed job #3183

Conversation

purelind
Copy link
Collaborator

Temporary disable failed job merged_integration_common_test due to pingcap/tidb#56463, enable status reporting after fixing the test failure issue.

Copy link

ti-chi-bot bot commented Oct 28, 2024

I have already done a preliminary review for you, and I hope to help you do a better job.

Based on the pull request title, description, and diff, the key change is to disable the failed job merged_integration_common_test temporarily by setting the skip_report flag to true. The reason for disabling the job is due to a test failure issue that needs to be fixed. The intention is to enable the status reporting again after the test issue is resolved.

There are no potential problems with this pull request as it is a standard practice to disable a job temporarily if it is failing. However, it is essential to ensure that the job is re-enabled once the issue is fixed.

As a fixing suggestion, the pull request author can add a comment on the pull request indicating the expected timeline for fixing the test failure issue and re-enabling the job. This will help in keeping all team members informed and ensure that the job is re-enabled as soon as possible.

@ti-chi-bot ti-chi-bot bot added the lgtm label Oct 28, 2024
Copy link

ti-chi-bot bot commented Oct 28, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wuhuizuo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

ti-chi-bot bot commented Oct 28, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-10-28 02:34:07.466825329 +0000 UTC m=+230760.305980867: ☑️ agreed by wuhuizuo.

@ti-chi-bot ti-chi-bot bot added the approved label Oct 28, 2024
@wuhuizuo
Copy link
Collaborator

/cc @bb7133

@ti-chi-bot ti-chi-bot bot requested a review from bb7133 October 28, 2024 02:34
@ti-chi-bot ti-chi-bot bot merged commit b9d6b7d into PingCAP-QE:main Oct 28, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants