Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: to use clang-format 12 for tiflash version less than v7.4 #3178

Conversation

purelind
Copy link
Collaborator

for version <= 7.4, need use clang-format 12

Copy link

ti-chi-bot bot commented Oct 17, 2024

I have already done a preliminary review for you, and I hope to help you do a better job.

Based on the pull request, the key changes include:

  • Adding a new stage called "clang-format-12" to the pull_integration_test.groovy file.
  • Copying the clang-format-12 file to /usr/local/bin/clang-format and making it executable.
  • This change is applicable for the Tiflash version less than or equal to 7.4.

There are no apparent potential problems with this pull request. However, it is recommended to consider the following suggestions:

  • It is always a good practice to provide more detailed information in the pull request description, such as the reason behind the change and the expected outcome.
  • It may be useful to add a check to ensure that the Tiflash version is less than or equal to 7.4 before running the "clang-format-12" stage.
  • It may be helpful to add a comment in the code to explain the purpose of the "clang-format-12" stage.

Overall, the changes seem justified and should not cause any issues.

Copy link

ti-chi-bot bot commented Oct 17, 2024

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the size/S label Oct 17, 2024
@ti-chi-bot ti-chi-bot bot merged commit 85250fd into PingCAP-QE:main Oct 17, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant