-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix RocksDB CI #3125
Fix RocksDB CI #3125
Conversation
Based on the pull request description and changes, it seems like the author has fixed an issue with RocksDB CI. The key change is that the As for potential problems, I don't see any issues with the changes themselves. However, it's possible that the removal of For fixing suggestions, I recommend testing the changes locally and ensuring that all tests pass. Additionally, it might be a good idea to double-check with other team members to make sure that removing |
Based on the PR title and the diff, it seems that the changes are related to fixing the Continuous Integration (CI) pipeline for RocksDB testing. The key changes involve removing the use of temporary directories for testing, and instead using a fixed directory for testing. One potential problem is that the removal of temporary directories may affect some RocksDB tests. It would be useful to investigate whether this is the case and if so, whether there is a way to address it. As for fixing suggestions, it may be helpful to investigate the issue with temporary directories and determine whether there is a way to use them without affecting the tests. Alternatively, if using a fixed directory is the only solution, it may be helpful to document this change and its potential impact on the tests. Additionally, it may be useful to add more comments to the code to explain the changes made. |
Based on the diff provided, it seems that the changes in this pull request are related to fixing the RocksDB CI tests. Specifically, the changes involve modifying the One potential problem with this change is that it may cause issues with certain RocksDB tests that require a temporary directory. It's unclear from the pull request description whether this issue has been considered and addressed. To fix this potential issue, it may be worth investigating whether there are certain tests that require a temporary directory and modifying the Overall, the changes in this pull request seem straightforward and should improve the reliability of the RocksDB CI tests. However, it's important to ensure that all relevant test cases are still being properly evaluated. |
Based on the diff, it seems that this pull request addresses an issue with the CI for RocksDB. The changes consist of removing a variable called "use_tmp" from the "test" function and setting the "TEST_TMPDIR" environment variable to "/home/jenkins/tmp_dir". There are no obvious potential problems with these changes. However, it is unclear why the "use_tmp" variable was removed, and whether this could cause any issues. Additionally, it is not stated whether "/home/jenkins/tmp_dir" is a safe and appropriate location to set the "TEST_TMPDIR" variable. Some suggestions to improve this pull request are:
|
[LGTM Timeline notifier]Timeline:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: purelind, wuhuizuo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
No description provided.