feat: switch to use new pipeline trigger by prow in branch 8.1 #3116
Conversation
Based on the pull request description and the diff, it seems that the changes are related to switching to a new pipeline trigger by prow in tikv and tiflash branches release-8.1. The changes include adding the release-8.1 branch to the blacklist target branches in the relevant files and updating the release-8.1-presubmits.yaml file for the tiflash and tikv branches. One potential problem I see is that the changes are only made for the release-8.1 branch, which means that other branches may not be using the new pipeline trigger. It would be good to confirm that the new trigger is working as expected on all relevant branches. Another potential problem is that the changes to the release-8.1-presubmits.yaml file for tiflash and tikv seem to be contradictory. The pull_unit_test job is set to always run, but optional and with skip_report set to true, while the pull_integration_test job is set to run only if triggered and not optional, with skip_report set to false. This may cause confusion and inconsistencies in the test results. It would be good to review the settings and ensure they are consistent and clear. My suggested fixes would be to confirm that the new trigger is working as expected on all relevant branches, and to review the settings in the release-8.1-presubmits.yaml file for tiflash and tikv to ensure they are consistent and clear. For example, the jobs could be set to always run and not optional, with skip_report set to false for both pull_unit_test and pull_integration_test. This will ensure that the tests are always run and the results are reported consistently. |
|
/hold |
|
@purelind: GitHub didn't allow me to request PR reviews from the following users: zhangjinpeng1987. Note that only PingCAP-QE members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@glorv: adding LGTM is restricted to approvers and reviewers in OWNERS files. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
tiflash
tikv
|
|
/lgtm wait for more LGTMs |
[LGTM Timeline notifier]Timeline:
|
|
@zanmato1984: adding LGTM is restricted to approvers and reviewers in OWNERS files. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@Lloyd-Pottiger: adding LGTM is restricted to approvers and reviewers in OWNERS files. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: glorv, Lloyd-Pottiger, wuhuizuo, zanmato1984 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/unhold |
Swtich to use new pipeline trigger by prow in tikv & tiflash branch release-8.1