-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RocksDB CI: use static link #3108
Conversation
Signed-off-by: Yang Zhang <yang.zhang@pingcap.com>
Based on the pull request title and description, it seems that the change is to switch from dynamic link to static link for RocksDB CI. The change is made by adding a The potential problem I see is that switching to static link may increase the binary size and make it less efficient. It may also cause problems with dependencies if they are not statically linked as well. The reason why the project switched to dynamic link may need to be investigated further. As for fixing suggestions, it would be good to test the impact of this change on binary size and performance. It may also be useful to investigate the reasons why the project switched to dynamic link in the first place and see if there are any new issues that may arise from switching back to static link. Additionally, it may be helpful to check if all necessary dependencies are statically linked as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: purelind The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
/hold |
/unhold |
RocksDB switched to dynamic link. We may want to stick to static link for better portability,