Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RocksDB CI: use static link #3108

Merged
merged 1 commit into from
Sep 6, 2024

Conversation

v01dstar
Copy link
Contributor

@v01dstar v01dstar commented Sep 6, 2024

RocksDB switched to dynamic link. We may want to stick to static link for better portability,

Signed-off-by: Yang Zhang <yang.zhang@pingcap.com>
Copy link

ti-chi-bot bot commented Sep 6, 2024

I have already done a preliminary review for you, and I hope to help you do a better job.

Based on the pull request title and description, it seems that the change is to switch from dynamic link to static link for RocksDB CI. The change is made by adding a LIB_MODE=static flag to the build command in two files.

The potential problem I see is that switching to static link may increase the binary size and make it less efficient. It may also cause problems with dependencies if they are not statically linked as well. The reason why the project switched to dynamic link may need to be investigated further.

As for fixing suggestions, it would be good to test the impact of this change on binary size and performance. It may also be useful to investigate the reasons why the project switched to dynamic link in the first place and see if there are any new issues that may arise from switching back to static link. Additionally, it may be helpful to check if all necessary dependencies are statically linked as well.

@ti-chi-bot ti-chi-bot bot requested review from purelind and wuhuizuo September 6, 2024 06:10
@ti-chi-bot ti-chi-bot bot added the size/XS label Sep 6, 2024
Copy link
Collaborator

@purelind purelind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

ti-chi-bot bot commented Sep 6, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: purelind

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the lgtm label Sep 6, 2024
Copy link

ti-chi-bot bot commented Sep 6, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-09-06 06:16:19.012089694 +0000 UTC m=+597903.530142615: ☑️ agreed by purelind.

@ti-chi-bot ti-chi-bot bot added the approved label Sep 6, 2024
@purelind
Copy link
Collaborator

purelind commented Sep 6, 2024

/hold

@purelind
Copy link
Collaborator

purelind commented Sep 6, 2024

/unhold

@ti-chi-bot ti-chi-bot bot merged commit 510f079 into PingCAP-QE:main Sep 6, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants