Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove wip/ on test passed pipelines #3075

Merged

Conversation

purelind
Copy link
Collaborator

@purelind purelind commented Aug 8, 2024

No description provided.

@ti-chi-bot ti-chi-bot bot requested a review from wuhuizuo August 8, 2024 04:25
Copy link

ti-chi-bot bot commented Aug 8, 2024

I have already done a preliminary review for you, and I hope to help you do a better job.

Based on the diff, it appears that the pull request removes the wip/ prefix from various pipeline contexts, making them match the actual pipeline names that are executed when the corresponding tests pass.

There don't seem to be any potential problems with this change, as long as the actual pipeline names are correct and the tests keep passing.

As for fixing suggestions, it would be good to double-check that the pipeline contexts match the actual pipeline names and ensure that all tests still pass after the change. Additionally, it might be a good idea to update any documentation or scripts that refer to the old wip/ prefix to avoid confusion in the future.

Copy link

ti-chi-bot bot commented Aug 8, 2024

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the size/S label Aug 8, 2024
@ti-chi-bot ti-chi-bot bot merged commit eddcd59 into PingCAP-QE:main Aug 8, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant