Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pingcap/tiflow,pingcap/pd): support feature branch #3036

Merged
merged 2 commits into from
Jul 29, 2024

Conversation

wuhuizuo
Copy link
Collaborator

Signed-off-by: wuhuizuo wuhuizuo@126.com

wuhuizuo added 2 commits July 29, 2024 14:05
Signed-off-by: wuhuizuo <wuhuizuo@126.com>
Copy link

ti-chi-bot bot commented Jul 29, 2024

I have already done a preliminary review for you, and I hope to help you do a better job.

Based on the title and description of the pull request, the key change seems to be adding support for feature branches in the presubmit jobs for the PingCAP TiDB, TiFlash, and TiFlow repositories. The diff shows that the latest-presubmits.yaml files for these repositories are being updated to include ^feature/.+ as a valid branch for the presubmit jobs.

There don't seem to be any potential problems with this change as it is only adding support for a new branch pattern and does not affect the existing jobs.

As for fixing suggestions, it would be good to ensure that the new branch pattern is thoroughly tested before merging the pull request. Additionally, it may be helpful to add some documentation or comments in the latest-presubmits.yaml files to explain the new branch pattern and its purpose.

Copy link

ti-chi-bot bot commented Jul 29, 2024

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot merged commit 6a0fce0 into main Jul 29, 2024
2 checks passed
@ti-chi-bot ti-chi-bot bot deleted the feature/feature-branch-ci branch July 29, 2024 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant