fix: shader cleanup in vulkan backend

PilotLightTech · May 29, 2024 · 7be8a64 · 7be8a64
1 parent 1e79184
commit 7be8a64
Show file tree

Hide file tree

Showing 5 changed files with 8 additions and 8 deletions.
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
@@ -55,7 +55,7 @@ jobs:
         if not exist ../out/example_2.dll exit 1
         if not exist ../out/example_3.dll exit 1
         if not exist ../out/example_4.dll exit 1
-        if not exist ../out/example_5.dll exit 1
+        if not exist ../out/example_8.dll exit 1
         if not exist ../out/pilot_light.exe exit 1
         if not exist ../out/pl_graphics_ext.dll exit 1
         if not exist ../out/pl_image_ext.dll exit 1
@@ -122,7 +122,7 @@ jobs:
         test -f ./out/example_2.dylib || exit 1
         test -f ./out/example_3.dylib || exit 1
         test -f ./out/example_4.dylib || exit 1
-        test -f ./out/example_5.dylib || exit 1
+        test -f ./out/example_8.dylib || exit 1
         test -f ./out/pl_stats_ext.dylib || exit 1
         test -f ./out/pl_image_ext.dylib || exit 1
         test -f ./out/pl_debug_ext.dylib || exit 1
@@ -201,7 +201,7 @@ jobs:
         test -f ./out/example_2.so || exit 1
         test -f ./out/example_3.so || exit 1
         test -f ./out/example_4.so || exit 1
-        test -f ./out/example_5.so || exit 1
+        test -f ./out/example_8.so || exit 1
         test -f ./out/pl_graphics_ext.so || exit 1
         test -f ./out/pl_image_ext.so || exit 1
         test -f ./out/pl_stats_ext.so || exit 1

diff --git a/examples/README.md b/examples/README.md
@@ -61,7 +61,7 @@ Demonstrates:
 * loading extensions
 * basic graphics extension use
 
-## Example 5 - Drawing Extension 3D (example_5.c)
+## Example 8 - Drawing Extension 3D (example_8.c)
 Demonstrates:
 * loading APIs
 * hot reloading

diff --git a/examples/example_5.c → examples/example_8.c b/examples/example_5.c → examples/example_8.c
@@ -1,5 +1,5 @@
 /*
-   example_5.c
+   example_8.c
      - demonstrates loading APIs
      - demonstrates loading extensions
      - demonstrates hot reloading
@@ -194,7 +194,7 @@ pl_app_load(plApiRegistryI* ptApiRegistry, plAppData* ptAppData)
 
     // use window API to create a window
     const plWindowDesc tWindowDesc = {
-        .pcName  = "Example 5",
+        .pcName  = "Example 8",
         .iXPos   = 200,
         .iYPos   = 200,
         .uWidth  = 600,

diff --git a/extensions/pl_graphics_vulkan.c b/extensions/pl_graphics_vulkan.c
@@ -5278,7 +5278,7 @@ pl_destroy_shader(plDevice* ptDevice, plShaderHandle tHandle)
     ptVariantVulkanResource->tPipelineLayout = VK_NULL_HANDLE;
     ptVariantVulkanResource->tPipeline = VK_NULL_HANDLE;
     pl_sb_push(ptGraphics->sbtShaderFreeIndices, tHandle.uIndex);
-    for(uint32_t k = 0; k < ptResource->tDescription.uBindGroupLayoutCount + 1; k++)
+    for(uint32_t k = 0; k < ptResource->tDescription.uBindGroupLayoutCount; k++)
     {
         plVulkanBindGroupLayout* ptVulkanBindGroupLayout = &ptVulkanGfx->sbtBindGroupLayouts[ptResource->tDescription.atBindGroupLayouts[k].uHandle];
         vkDestroyDescriptorSetLayout(ptVulkanDevice->tLogicalDevice, ptVulkanBindGroupLayout->tDescriptorSetLayout, NULL);   

diff --git a/scripts/gen_examples.py b/scripts/gen_examples.py
@@ -88,7 +88,7 @@ def add_example_app(name):
     add_example_app("example_2")
     add_example_app("example_3")
     add_example_app("example_4")
-    add_example_app("example_5")
+    add_example_app("example_8")
 
     vulkan_shaders = [
         "example_4.frag",