Add toggle to export playlist for older FT #62

PikachuEXE · 2023-11-22T00:01:47Z

Pull Request Type

Bugfix
Feature Implementation
Documentation
Other

Related issue

Addition to FreeTubeApp#4234

Description

New toggle to allow user to export playlists in a format consumable by old versions of FT

Screenshots

Testing

Checkout this PR, add some playlists and videos, probably also removed the default playlists
Export playlists as usual (also as backup file for different tests
Export playlists with new toggle on
Remove all playlists
Switch back to development, import the export with new toggle on
Confirm all videos from all playlists are present

Desktop

OS:
OS Version:
FreeTube version:

Additional context

kommunarr · 2023-11-22T01:37:22Z

Haven't tested yet, but here's my suggestion on the tooltip text:

This option exports all playlist videos into one Favorites playlist.
To use your current playlists in an older version of FreeTube:
1. Export your playlists using this option.
2. Delete all of your existing playlists using the Remove All Playlists option under Privacy Settings.
3. Load up the older version of FreeTube and import your playlists.

PikachuEXE · 2023-11-22T01:43:18Z

Counter suggestion

This option exports videos from all playlists into one playlist named Favorites.
How to export & import videos in playlists for an older version of FreeTube:

Export your playlists with this option enabled.
Delete all of your existing playlists using the Remove All Playlists option under Privacy Settings.
Launch the older version of FreeTube and import the exported playlists.

kommunarr · 2023-11-22T02:20:19Z

Sounds good. Try to keep the line breaks in the tooltip if possible, but it's ok if not

PikachuEXE · 2023-11-22T05:31:53Z

Try to keep the line breaks in the tooltip if possible

How to do that, any existing example?

PikachuEXE · 2023-11-22T06:13:14Z

No existing example, need to create new option to allow new lines

kommunarr · 2023-11-22T13:23:29Z

This looks good, although it still is not very easy to follow the bullets when they're centered. Would it be too much to ask to have the text be start or end aligned as well?

PikachuEXE · 2023-11-22T13:50:01Z

I guess I will just make them all left align (when new line enabled)
Wondering if all tooltips should be converted to enable new line later (out of scope)

kommunarr · 2023-11-22T14:20:09Z

Good thinking, I think that should be fine as long as we're intentional about how we use the block style indicator for any other tooltips (currently just the External Link Handling one AFAICS).

PikachuEXE · 2023-11-23T00:27:38Z

Updated

PikachuEXE · 2023-11-23T00:35:17Z

Fixed the annoying extra surrounding spaces

kommunarr · 2023-11-23T00:35:57Z

static/locales/en-US.yaml

+      Label: Export Playlists For Older FreeTube Versions
+      # |- = Keep newlines, No newline at end
+      Tooltip: |-
+        This option exports videos from all playlists into one playlist named `Favorites`.


nitpick: use quotes, not backticks

kommunarr · 2023-11-23T00:40:05Z

nitpick: new pattern especially necessitates max fixed width (as % or vw). Edit: or as fixed max width in px. Would have to check our tooltip code to see how it's being done now, but it looks to stay pretty consistently constrained width-wise across our different tooltips.

kommunarr · 2023-11-23T00:48:05Z

src/renderer/components/data-settings/data-settings.js

+        })
+      })
+
+      await this.promptAndWriteToFile(options, JSON.stringify([favoritesPlaylistData]), 'All playlists has been successfully exported')


nitpick: String needs to be localized (multiple instances)

It's a translation key suffix

Thanks, didn't see that - I forgot about this from Chunky's recent linting PR - no problem here

kommunarr · 2023-11-23T00:51:26Z

src/renderer/components/data-settings/data-settings.js

+
+    exportPlaylistsForOlderVersions: async function () {
+      const dateStr = getTodayDateStrLocalTimezone()
+      const exportFileName = 'freetube-playlists-for-single-favorites-playlist-' + dateStr + '.db'


suggestion (non-blocking):

Suggested change

const exportFileName = 'freetube-playlists-for-single-favorites-playlist-' + dateStr + '.db'

const exportFileName = 'freetube-playlists-as-single-favorites-playlist-' + dateStr + '.db'

kommunarr · 2023-11-23T00:53:34Z

Testing: worked well for me! Handled multiple playlists with multiple overlapping duplicates. Using the instructions, it was imported to my nightly build without any duplicates or issues.

PikachuEXE · 2023-11-23T01:30:24Z

Breakpoint now set at 1000px to wrap

Temp note for myself: https://gomakethings.com/how-to-check-if-any-part-of-an-element-is-out-of-the-viewport-with-vanilla-js/

kommunarr · 2023-11-23T02:09:27Z

issue (non-blocking) Still seems risky with other more verbose languages (demonstration below). But not a blocking issue if we want to put a pin in that.

PikachuEXE · 2023-11-23T03:42:51Z

Just made tooltip auto-wrap

kommunarr · 2023-11-23T04:15:31Z

Not sure where this was from but it seems a bit overengineered and isn't working right on some devices (tested with iPhone XR devtool). Why not just use a max-inline-size or something to that effect?

This reverts commit 7d932b9.

kommunarr · 2023-11-23T04:20:52Z

Even just this without the media query looks fine:

  white-space: pre-wrap;
  text-align: start;
  min-inline-size: 55vw;
}

kommunarr · 2023-11-23T04:30:00Z

Here's my suggestion: #63

Feat/change tooltip styling

PikachuEXE · 2023-11-23T06:12:31Z

I rarely used vw to know how to use them properly -_-

kommunarr

It's not too often honestly, but it makes sense here with us trying to keep an absolutely positioned popup within dynamic screen constraints. LGTM.

+ Add toggle to export playlist for older FT

d8b149c

github-actions bot added the PR: waiting for review label Nov 22, 2023

PikachuEXE mentioned this pull request Nov 22, 2023

(Multiple) Local Playlist (instead of saving video in one hidden list) FreeTubeApp/FreeTube#4234

Merged

3 tasks

* Update tooltip text

94f0463

* Update text align

f1225cf

* Remove the extra surrounding spaces

fe8440d

kommunarr reviewed Nov 23, 2023

View reviewed changes

Backtick > quote

1a96092

kommunarr reviewed Nov 23, 2023

View reviewed changes

Fix tootip in lower width view

fd74dc9

Update default filename

73626f6

* Make tooltip auto-wrap

7d932b9

Revert "* Make tooltip auto-wrap"

8c73360

This reverts commit 7d932b9.

Adjust tooltip styling

a968655

Merge pull request #63 from jasonhenriquez/feat/change-tooltip-styling

8b1fe42

Feat/change tooltip styling

kommunarr approved these changes Nov 23, 2023

View reviewed changes

PikachuEXE merged commit dbe57a4 into feature/playlist-2023-05 Nov 23, 2023

github-actions bot removed the PR: waiting for review label Nov 23, 2023

PikachuEXE mentioned this pull request Nov 23, 2023

Multiple user playlist export data handling FreeTubeApp/FreeTube#4353

Closed

4 tasks

PikachuEXE deleted the feature/playlist-2023-05-w-old-ft-consumable-playlist-export branch December 5, 2023 06:13

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add toggle to export playlist for older FT #62

Add toggle to export playlist for older FT #62

PikachuEXE commented Nov 22, 2023

kommunarr commented Nov 22, 2023 •

edited

Loading

PikachuEXE commented Nov 22, 2023

kommunarr commented Nov 22, 2023

PikachuEXE commented Nov 22, 2023 •

edited

Loading

PikachuEXE commented Nov 22, 2023

kommunarr commented Nov 22, 2023

PikachuEXE commented Nov 22, 2023

kommunarr commented Nov 22, 2023

PikachuEXE commented Nov 23, 2023

PikachuEXE commented Nov 23, 2023

kommunarr Nov 23, 2023

PikachuEXE Nov 23, 2023

kommunarr commented Nov 23, 2023 •

edited

Loading

kommunarr Nov 23, 2023

PikachuEXE Nov 23, 2023

kommunarr Nov 23, 2023 •

edited

Loading

kommunarr Nov 23, 2023

PikachuEXE Nov 23, 2023

kommunarr commented Nov 23, 2023

PikachuEXE commented Nov 23, 2023 •

edited

Loading

kommunarr commented Nov 23, 2023

PikachuEXE commented Nov 23, 2023

kommunarr commented Nov 23, 2023

kommunarr commented Nov 23, 2023

kommunarr commented Nov 23, 2023

PikachuEXE commented Nov 23, 2023

kommunarr left a comment

	const exportFileName = 'freetube-playlists-for-single-favorites-playlist-' + dateStr + '.db'
	const exportFileName = 'freetube-playlists-as-single-favorites-playlist-' + dateStr + '.db'

Add toggle to export playlist for older FT #62

Add toggle to export playlist for older FT #62

Conversation

PikachuEXE commented Nov 22, 2023

Pull Request Type

Related issue

Description

Screenshots

Testing

Desktop

Additional context

kommunarr commented Nov 22, 2023 • edited Loading

PikachuEXE commented Nov 22, 2023

kommunarr commented Nov 22, 2023

PikachuEXE commented Nov 22, 2023 • edited Loading

PikachuEXE commented Nov 22, 2023

kommunarr commented Nov 22, 2023

PikachuEXE commented Nov 22, 2023

kommunarr commented Nov 22, 2023

PikachuEXE commented Nov 23, 2023

PikachuEXE commented Nov 23, 2023

kommunarr Nov 23, 2023

Choose a reason for hiding this comment

PikachuEXE Nov 23, 2023

Choose a reason for hiding this comment

kommunarr commented Nov 23, 2023 • edited Loading

kommunarr Nov 23, 2023

Choose a reason for hiding this comment

PikachuEXE Nov 23, 2023

Choose a reason for hiding this comment

kommunarr Nov 23, 2023 • edited Loading

Choose a reason for hiding this comment

kommunarr Nov 23, 2023

Choose a reason for hiding this comment

PikachuEXE Nov 23, 2023

Choose a reason for hiding this comment

kommunarr commented Nov 23, 2023

PikachuEXE commented Nov 23, 2023 • edited Loading

kommunarr commented Nov 23, 2023

PikachuEXE commented Nov 23, 2023

kommunarr commented Nov 23, 2023

kommunarr commented Nov 23, 2023

kommunarr commented Nov 23, 2023

PikachuEXE commented Nov 23, 2023

kommunarr left a comment

Choose a reason for hiding this comment

kommunarr commented Nov 22, 2023 •

edited

Loading

PikachuEXE commented Nov 22, 2023 •

edited

Loading

kommunarr commented Nov 23, 2023 •

edited

Loading

kommunarr Nov 23, 2023 •

edited

Loading

PikachuEXE commented Nov 23, 2023 •

edited

Loading